Ztri 32 markdown to jsx #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt page and make get request for the content Co-authored-by: jamesj-0 <[email protected]>
…ontent component Co-authored-by: jamesj-0 <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #32 +/- ##
==========================================
- Coverage 59.38% 57.81% -1.57%
==========================================
Files 36 38 +2
Lines 261 275 +14
Branches 15 15
==========================================
+ Hits 155 159 +4
- Misses 102 112 +10
Partials 4 4
Continue to review full report at Codecov.
|
VatsKan
reviewed
Jun 16, 2020
| @@ -23,6 +23,7 @@ | |||
| "@typescript-eslint/parser": "^3.2.0", | |||
| "airtable": "^0.8.1", | |||
| "inquirer": "^7.1.0", | |||
| "markdown-to-jsx": "^6.11.4", | |||
There was a problem hiding this comment.
i see youve added another dependency interesting
VatsKan
reviewed
Jun 16, 2020
| import PropTypes from 'prop-types'; | ||
| // import Markdown from 'markdown-to-jsx'; | ||
|
|
||
| import * as SC from './style'; |
There was a problem hiding this comment.
VatsKan
approved these changes
Jun 16, 2020
| @@ -10,6 +10,7 @@ export const offWhite = '#fbf9fa'; | |||
| export const medButtonHeight = '42px'; | |||
| export const smallButtonHeight = '38px'; | |||
| export const titleBarVerticalPadding = '8px'; | |||
| export const mainContainerWidth = '700px'; | |||
There was a problem hiding this comment.
nice use of relative units
|
well done folks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.