Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Action Buttopn bug & misc tweaks #107

Merged
merged 7 commits into from
Dec 18, 2024
Merged

New Action Buttopn bug & misc tweaks #107

merged 7 commits into from
Dec 18, 2024

Conversation

JasonWarrenUK
Copy link
Collaborator

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Styling
  • Build
  • Chore

Description

Fixed Add New Action functionality

Previously it was doing this for each selected Need

if (actions > 0) {
  <NewActionsSection/>
}

export default NewActionsSection() {
  return (
    /* render actions */
    /* render new actions button */
  )
}

Now it's doing this:

<NewActionsSection/>

export default NewActionsSection() {
  return (
    if (actions > 0) {
      /* render actions */
    }
    
    /* render new actions button */
  )
}

Miscellaneous

  • changed text colour on new actions page
  • changed "categories" to "tags" on toolkit info page

Screenshots

NO

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Semantic HTML implemented?
  • Checked with axe DevTools and addressed Critical and Serious issues?
  • Color contrast tested?

Added/updated tests?

Please aim to keep the code coverage percentage at 80% and above.

  • Yes
  • No, and this is why: you said I could not so thx QA daddies
  • I need help with writing tests

Delete branch after merge?

  • Yes
  • No

What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented Dec 18, 2024

Deploy Preview for thingswedo ready!

Name Link
🔨 Latest commit 26af30e
🔍 Latest deploy log https://app.netlify.com/sites/thingswedo/deploys/6762b26f5cbb27000891cc26
😎 Deploy Preview https://deploy-preview-107--thingswedo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@maxitect maxitect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay last bug fixed! Thank you sir!

@maxitect maxitect merged commit d4d3603 into main Dec 18, 2024
5 checks passed
@maxitect maxitect deleted the JasonWarrenUK-patch-1 branch December 18, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants