Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/highlight navbar #11

Merged
merged 5 commits into from
Nov 27, 2024
Merged

Feature/highlight navbar #11

merged 5 commits into from
Nov 27, 2024

Conversation

jackcasstlesjones
Copy link
Collaborator

@jackcasstlesjones jackcasstlesjones commented Nov 27, 2024

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

  • Installed clsx package
  • Active navbar link now has lighter background

Screenshots

Screenshot 2024-11-27 at 16 30 20 Screenshot 2024-11-27 at 16 30 15

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Semantic HTML implemented?
  • Checked with axe DevTools and addressed Critical and Serious issues?
  • Color contrast tested?

Added/updated tests?

Please aim to keep the code coverage percentage at 80% and above.

  • Yes
  • No, and this is why: please replace this line with details on why tests
    have not been included
  • I need help with writing tests

What gif best describes this PR or how it makes you feel?

alt_text

@JasonWarrenUK
Copy link
Collaborator

You've written no tests. I approve.

Copy link
Collaborator

@JasonWarrenUK JasonWarrenUK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No tests written.

I approve.

@maxitect maxitect merged commit d1596d9 into main Nov 27, 2024
1 check failed
@maxitect maxitect deleted the feature/highlight-navbar branch November 27, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants