Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup/plotly #13

Merged
merged 5 commits into from
Nov 28, 2024
Merged

Setup/plotly #13

merged 5 commits into from
Nov 28, 2024

Conversation

maxitect
Copy link
Collaborator

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

  • Installed plotly, react-plotly and type dependencies
  • Added PlotlyChart.tsx component to wrap a chart in a React/Typescript component
  • 3x merges with main

Screenshots

Test graphs - not in this PR but using the PlotlyChart component on a page as a test
image

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Semantic HTML implemented?
  • Checked with axe DevTools and addressed Critical and Serious issues?
  • Color contrast tested?

Added/updated tests?

Please aim to keep the code coverage percentage at 80% and above.

  • Yes
  • No, and this is why: manual test included in the screenshot above
  • I need help with writing tests

What gif best describes this PR or how it makes you feel?

codepenguin

Copy link
Collaborator

@jackcasstlesjones jackcasstlesjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plotly ftw

@jackcasstlesjones jackcasstlesjones merged commit 2dc470d into main Nov 28, 2024
1 check failed
@jackcasstlesjones jackcasstlesjones deleted the setup/plotly branch November 28, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants