Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Needs/data #68

Merged
merged 13 commits into from
Dec 10, 2024
Merged

Needs/data #68

merged 13 commits into from
Dec 10, 2024

Conversation

maxitect
Copy link
Collaborator

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Styling
  • Build
  • Chore

Description

Summary

This pull request focuses on adding 3 database collections for the needs tab: needs_categories, needs, next_actions.

Updates

  • Schema Enhancements:
    • Updated category and toolkit item schemas to include string limits for better data validation.
    • Added schemas for:
      • Needs Categories
      • Needs
      • Next Actions
  • Refactoring:
    • Moved toolkit seed data into its own file for improved modularity.
    • Renamed variables for clarity and maintainability across the codebase.
    • Removed confusing database seeding logs to streamline console outputs.
  • Seed Data Preparation:
    • Prepared seed data for needs categories, needs, and next actions in needs.ts.
    • Added collections for needs categories, needs, and next actions alongside corresponding seed data to ensure proper database population.
  • Bug Fixes:
    • Fixed schema and collection pairing issues, ensuring schemas are correctly associated with their respective collections.
  • Merges:

These updates improve the consistency, maintainability, and scalability of the database layer, while ensuring seed data and schemas are well-structured and logically organized.

Screenshots

Database update, no UI changes

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Semantic HTML implemented?
  • Checked with axe DevTools and addressed Critical and Serious issues?
  • Color contrast tested?

Added/updated tests?

Please aim to keep the code coverage percentage at 80% and above.

  • Yes
  • No, and this is why: please replace this line with details on why tests
    have not been included
  • I need help with writing tests

Delete branch after merge?

  • Yes
  • No

What gif best describes this PR or how it makes you feel?

yes

Copy link

netlify bot commented Dec 10, 2024

Deploy Preview for thingswedo ready!

Name Link
🔨 Latest commit 36d727d
🔍 Latest deploy log https://app.netlify.com/sites/thingswedo/deploys/67586f7c29c98e00085300f8
😎 Deploy Preview https://deploy-preview-68--thingswedo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jackcasstlesjones jackcasstlesjones merged commit 6cd2705 into main Dec 10, 2024
5 checks passed
@jackcasstlesjones jackcasstlesjones deleted the needs/data branch December 10, 2024 17:28
maxitect added a commit that referenced this pull request Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants