Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch Protection Rules #7

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Branch Protection Rules #7

merged 2 commits into from
Nov 27, 2024

Conversation

JasonWarrenUK
Copy link
Collaborator

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • NONE OF THESE OPTIONS ACTUALLY

Description

Two files created in .github/

  • .github/CODEOWNERS defines Max & Jack as co owners of all code, so they are called for review
  • .github/workflows/review-logic.yml works out who has to review based on code writer, code owner etc etc

Added/updated tests?

Please aim to keep the code coverage percentage at 80% and above.

  • Yes
  • No, and this is why: it's a repo file
  • I need help with writing tests

What gif best describes this PR or how it makes you feel?

@maxitect maxitect merged commit 08b960e into main Nov 27, 2024
1 check failed
@maxitect maxitect deleted the ci/branch-potection-rules branch November 27, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants