Feature: add graceful fallback alternatives for img and link in toolkitpage #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gurtatiLND
requested review from
maxitect and
jackcasstlesjones
as code owners
✅ Deploy Preview for thingswedo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
maxitect
previously approved these changes
Dec 11, 2024
Comment on lines
19
to
28
| // const isValidUrl = (url: string | undefined): boolean => { | ||
| // if (!url) return false; | ||
| // try { | ||
| // new URL(url); | ||
| // return true; | ||
| // } catch { | ||
| // return false; | ||
| // } | ||
| // }; | ||
|
|
There was a problem hiding this comment.
Suggested change
| // const isValidUrl = (url: string | undefined): boolean => { | |
| // if (!url) return false; | |
| // try { | |
| // new URL(url); | |
| // return true; | |
| // } catch { | |
| // return false; | |
| // } | |
| // }; | |
| // const isValidUrl = (url: string | undefined): boolean => { | |
| // if (!url) return false; | |
| // try { | |
| // new URL(url); | |
| // return true; | |
| // } catch { | |
| // return false; | |
| // } | |
| // }; |
Do we need to add this commented out code? [will not block merge]
maxitect
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Screenshots
UI accessibility checklist
If your PR includes UI changes, please utilize this checklist:
CriticalandSeriousissues?Added/updated tests?
Please aim to keep the code coverage percentage at 80% and above.
Delete branch after merge?
What gif best describes this PR or how it makes you feel?