Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App-wide UI styling #76

Merged
merged 61 commits into from
Dec 13, 2024
Merged

App-wide UI styling #76

merged 61 commits into from
Dec 13, 2024

Conversation

jackcasstlesjones
Copy link
Collaborator

@jackcasstlesjones jackcasstlesjones commented Dec 12, 2024

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Styling
  • Build
  • Chore

Description

App-wide UI styling, as discussed

Screenshots

Screenshot 2024-12-13 at 19 40 11
Screenshot 2024-12-13 at 19 40 20
Screenshot 2024-12-13 at 19 40 28
Screenshot 2024-12-13 at 19 40 40
Screenshot 2024-12-13 at 19 40 53

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Semantic HTML implemented?
  • Checked with axe DevTools and addressed Critical and Serious issues?
  • Color contrast tested?

Added/updated tests?

Please aim to keep the code coverage percentage at 80% and above.

  • Yes
  • No, and this is why: please replace this line with details on why tests
    have not been included
  • I need help with writing tests

Delete branch after merge?

  • Yes
  • No

What gif best describes this PR or how it makes you feel?

alt_text

Copy link

netlify bot commented Dec 12, 2024

Deploy Preview for thingswedo ready!

Name Link
🔨 Latest commit e23e950
🔍 Latest deploy log https://app.netlify.com/sites/thingswedo/deploys/675cb0495bc99d0008afc1d8
😎 Deploy Preview https://deploy-preview-76--thingswedo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jackcasstlesjones jackcasstlesjones changed the title DO NOT MERGE testing on phone App-wide UI styling Dec 13, 2024
@jackcasstlesjones jackcasstlesjones marked this pull request as ready for review December 13, 2024 20:45
Copy link
Collaborator

@maxitect maxitect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks so professional now, thanks for going through the whole UI making it look top notch! Couple of suggestions for accessibility

@maxitect maxitect merged commit 7202afd into main Dec 13, 2024
5 checks passed
@maxitect maxitect deleted the style/ui-changes branch December 13, 2024 22:19
maxitect added a commit that referenced this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants