Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style/logo #77

Merged
merged 4 commits into from
Dec 13, 2024
Merged

Style/logo #77

merged 4 commits into from
Dec 13, 2024

Conversation

maxitect
Copy link
Collaborator

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Styling
  • Build
  • Chore

Description

Quick initial design on logo, image files added as per nextjs docs: https://nextjs.org/docs/app/api-reference/file-conventions/metadata/app-icons
Suggest to use this as it is now, and come back to it next week when we have a bit more time. Happy to take comments, its not perfect :)

Screenshots

apple-icon

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Semantic HTML implemented?
  • Checked with axe DevTools and addressed Critical and Serious issues?
  • Color contrast tested?

Added/updated tests?

Please aim to keep the code coverage percentage at 80% and above.

  • Yes
  • No, and this is why: image files
  • I need help with writing tests

Delete branch after merge?

  • Yes
  • No

What gif best describes this PR or how it makes you feel?

rubixcube

Copy link

netlify bot commented Dec 13, 2024

Deploy Preview for thingswedo ready!

Name Link
🔨 Latest commit 9a3ae62
🔍 Latest deploy log https://app.netlify.com/sites/thingswedo/deploys/675c21af6d66370008f365f3
😎 Deploy Preview https://deploy-preview-77--thingswedo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@jackcasstlesjones jackcasstlesjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it IS perfect

@jackcasstlesjones jackcasstlesjones merged commit c1507e3 into main Dec 13, 2024
5 checks passed
@jackcasstlesjones jackcasstlesjones deleted the style/logo branch December 13, 2024 14:16
@maxitect maxitect restored the style/logo branch December 13, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants