Feature/needs page #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rise next actions by need
…d expiry and highlight
…cess needs states
✅ Deploy Preview for thingswedo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jackcasstlesjones
approved these changes
Dec 13, 2024
| className={clsx( | ||
| "fixed right-4 bottom-24 text-white rounded", | ||
| hasHighlightedNeeds | ||
| ? "bg-twd-primary-purple shadow-twd-primary-purple shadow-glow" |
There was a problem hiding this comment.
pls remove the glow, apart from the toolkit navbar button, no buttons in the app should have the glow
| className={clsx( | ||
| "fixed right-4 bottom-24 text-white rounded", | ||
| hasHighlightedNeeds | ||
| ? "bg-twd-primary-purple shadow-twd-primary-purple shadow-glow" |
There was a problem hiding this comment.
Suggested change
| ? "bg-twd-primary-purple shadow-twd-primary-purple shadow-glow" | |
| ? "bg-twd-primary-purple shadow-twd-primary-purple" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Summary
This pull request introduces a fully function needs tab with all database connections! And a working next actions page with no interaction (but filtered next actions).
Updates
Generic Components Refactoring:
NeedsSection.tsxandNeedsDisplay.tsxinto genericSection.tsxandDisplay.tsxcomponents for reusability.Display.tsxcomponent to support extensions, enabling modular functionality for needs and next actions pages.Needs and Next Actions Enhancements:
Display.tsxcomponent./next-actionsroute inNeedsDisplay.tsx.Database Integration:
DatabaseManager.tswith generic types and improved methods for handling nested objects and JSON access.orderandnameattributes and aligned seed data.State Management and Performance:
Display.tsxto optimize performance and simplify interactions.Accessibility and Styling:
Section.tsx.NeedsModal.tsxwith aria-labels on buttons for improved accessibility.Button.tsxfor better user feedback.Code Cleanup and Testing:
NeedsDisplay.tsxNeedsModal.tsxSection.tsxMerges:
Key Features
These updates deliver a scalable, maintainable, and user-friendly application architecture while enhancing performance, usability, and accessibility.
Screenshots
UI accessibility checklist
If your PR includes UI changes, please utilize this checklist:
CriticalandSeriousissues?Added/updated tests?
Please aim to keep the code coverage percentage at 80% and above.
have not been included
Delete branch after merge?
What gif best describes this PR or how it makes you feel?