Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/navbar #8

Merged
merged 11 commits into from
Nov 27, 2024
Merged

Feature/navbar #8

merged 11 commits into from
Nov 27, 2024

Conversation

jackcasstlesjones
Copy link
Collaborator

@jackcasstlesjones jackcasstlesjones commented Nov 27, 2024

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

  • Added Navbar, Navbar buttons, and Icon component
  • Fixed tailwind config
  • Added navbar to Root Layout
  • Lots of other changes because of Prettier formatting - apologies for this
  • Added page.tsx files for needs and insights

Screenshots

Screenshot 2024-11-27 at 14 14 55

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Semantic HTML implemented?
  • Checked with axe DevTools and addressed Critical and Serious issues?
  • Color contrast tested?

Added/updated tests?

Please aim to keep the code coverage percentage at 80% and above.

  • Yes
  • No, and this is why: please replace this line with details on why tests
    have not been included
  • I need help with writing tests

What gif best describes this PR or how it makes you feel?

alt_text

Copy link
Collaborator

@maxitect maxitect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments to either change or discuss

src/ui/shared/Icon.tsx Outdated Show resolved Hide resolved
src/ui/layout/Navbar/NavbarButtons.tsx Outdated Show resolved Hide resolved
gurtatiLND
gurtatiLND previously approved these changes Nov 27, 2024
@maxitect maxitect merged commit 1c84f88 into main Nov 27, 2024
1 check failed
@maxitect maxitect deleted the feature/navbar branch November 27, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants