-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Next Actions View #84
Conversation
✅ Deploy Preview for thingswedo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logic is solid, few comments based on what I think I understand just from code read, feel free to put me in my place if I'm missunderstanding xD
Thanks for persevering with this, I know it's been a bit of a pain!
Co-authored-by: Maxime Downe <[email protected]>
Co-authored-by: Maxime Downe <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work thanks for persevering again, couple minor comments
…ture/actions-view-sane-edition
What type of PR is this? (check all applicable)
Description
Core Feature
need.priority.order
need.priority.name
new Date()
to selectedTimestampsAdditional Features
changeCase()
utility functiongetPriorityColour()
utility functionNotes
__tests__
folder as an .md fileScreenshots
UI accessibility checklist
If your PR includes UI changes, please utilize this checklist:
Critical
andSerious
issues?Added/updated tests?
Please aim to keep the code coverage percentage at 80% and above.
Delete branch after merge?
What gif best describes this PR or how it makes you feel?