Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/general #85

Merged
merged 6 commits into from
Dec 16, 2024
Merged

Refactor/general #85

merged 6 commits into from
Dec 16, 2024

Conversation

maxitect
Copy link
Collaborator

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Styling
  • Build
  • Chore

Description

Summary

This pull request focuses on simplifying type definitions, refining component behaviors, and integrating recent updates from the main branch.

Updates

  • DatabaseManager Improvements:
    • Updated DatabaseManager.ts with the correct type for the getFromDb method, ensuring type safety and consistency.
  • Component Refactoring:
    • Simplified type definitions in the following components due to the updated DatabaseManager logic:
      • InsightsDisplay.tsx
      • ToolList.tsx
    • Refined CategoriesBar.tsx by removing outdated comments and adding required dependencies for improved maintainability.
  • UI Enhancements:
    • Increased z-index to z-20 for the InfoButton.tsx component to ensure it displays correctly above other UI elements.
  • Merges:

These updates streamline the codebase, enhance type clarity, and improve component behavior for a more reliable and maintainable application.

Screenshots

Please replace this line with any relevant images for UI changes.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Semantic HTML implemented?
  • Checked with axe DevTools and addressed Critical and Serious issues?
  • Color contrast tested?

Added/updated tests?

Please aim to keep the code coverage percentage at 80% and above.

  • Yes
  • No, and this is why: refactor, all tests pass
  • I need help with writing tests

Delete branch after merge?

  • Yes
  • No

What gif best describes this PR or how it makes you feel?

cowffee

Copy link

netlify bot commented Dec 16, 2024

Deploy Preview for thingswedo ready!

Name Link
🔨 Latest commit c09577a
🔍 Latest deploy log https://app.netlify.com/sites/thingswedo/deploys/676005fefe75b100087ed37c
😎 Deploy Preview https://deploy-preview-85--thingswedo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jackcasstlesjones jackcasstlesjones merged commit a97948f into main Dec 16, 2024
5 checks passed
@jackcasstlesjones jackcasstlesjones deleted the refactor/general branch December 16, 2024 11:06
maxitect added a commit that referenced this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants