Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style/colours #91

Merged
merged 12 commits into from
Dec 16, 2024
Merged

Style/colours #91

merged 12 commits into from
Dec 16, 2024

Conversation

maxitect
Copy link
Collaborator

@maxitect maxitect commented Dec 16, 2024

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Styling
  • Build
  • Chore

Description

Summary

This pull request updates the visual design of graph components to align with the latest Figma mood colors, latest colours from El and updates to the screenshots on the home page.

Updates

  • Color Updates:
    • Updated LineGraph.tsx, AreaChart.tsx, and StreamGraph.tsx to use the Figma mood colors for a consistent and polished look.
    • Created moodColours.json for colour mapping with moods used in both AreaChart.tsx and StreamGraph.tsx.
    • Added mood-to-color mappings in the JSON data document for better maintainability.
  • Graph Refinements:
    • Changed LineGraph.tsx to use linear plots instead of smooth splines, improving readability.
    • Updated aggregation logic in LineGraph.tsx for enhanced data clarity, aggregating daily data for month and week views.
  • Visual Assets:
    • Updated insights_screen.png to reflect the new mood colors and linear plot style.
    • Refreshed decisionMaker.png to remove the data point on "guilt."
  • Merges:

These updates enhance the visual clarity, consistency, and alignment of graph components with the latest design specifications.

Screenshots

Screen Shot 2024-12-16 at 17 44 45

Screen Shot 2024-12-16 at 17 44 50

Screen Shot 2024-12-16 at 17 44 17

Screen Shot 2024-12-16 at 17 44 21

Screen Shot 2024-12-16 at 17 44 26

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Semantic HTML implemented?
  • Checked with axe DevTools and addressed Critical and Serious issues?
  • Color contrast tested?

Added/updated tests?

Please aim to keep the code coverage percentage at 80% and above.

  • Yes
  • No, and this is why: style changes, all tests pass
  • I need help with writing tests

Delete branch after merge?

  • Yes
  • No

What gif best describes this PR or how it makes you feel?

yikes

Copy link

netlify bot commented Dec 16, 2024

Deploy Preview for thingswedo ready!

Name Link
🔨 Latest commit 3a4d306
🔍 Latest deploy log https://app.netlify.com/sites/thingswedo/deploys/67606c50e574f70008f08142
😎 Deploy Preview https://deploy-preview-91--thingswedo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jackcasstlesjones jackcasstlesjones merged commit 5780e8c into main Dec 16, 2024
5 checks passed
@jackcasstlesjones jackcasstlesjones deleted the style/colours branch December 16, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants