Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style/loading #99

Merged
merged 5 commits into from
Dec 17, 2024
Merged

Style/loading #99

merged 5 commits into from
Dec 17, 2024

Conversation

maxitect
Copy link
Collaborator

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Styling
  • Build
  • Chore

Description

Updating loading style of all loading messages based on Jack's styling, semantic html implemented to it to use p element rather than div for text.

Screenshots

Screen Shot 2024-12-17 at 15 39 40

Screen Shot 2024-12-17 at 15 39 14

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Semantic HTML implemented?
  • Checked with axe DevTools and addressed Critical and Serious issues?
  • Color contrast tested?

Added/updated tests?

Please aim to keep the code coverage percentage at 80% and above.

  • Yes
  • No, and this is why: all tests pass, just style change
  • I need help with writing tests

Delete branch after merge?

  • Yes
  • No

What gif best describes this PR or how it makes you feel?

blowdry

Copy link

netlify bot commented Dec 17, 2024

Deploy Preview for thingswedo ready!

Name Link
🔨 Latest commit a7b800e
🔍 Latest deploy log https://app.netlify.com/sites/thingswedo/deploys/67619b91e82b9100086b7a31
😎 Deploy Preview https://deploy-preview-99--thingswedo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jackcasstlesjones jackcasstlesjones merged commit 894d7f9 into main Dec 17, 2024
5 checks passed
@jackcasstlesjones jackcasstlesjones deleted the style/loading branch December 17, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants