Latest observations from MapData #3112
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66434621 |
ltiao
force-pushed
the
export-D66434621
branch
from
f9afc32 to
9027a1d
Compare
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Nov 26, 2024
Summary: Pull Request resolved: facebook#3112 Differential Revision: D66434621
|
This pull request was exported from Phabricator. Differential Revision: D66434621 |
ltiao
pushed a commit
to ltiao/Ax
that referenced
this pull request
Nov 26, 2024
Summary: Pull Request resolved: facebook#3112 Differential Revision: D66434621
ltiao
pushed a commit
to ltiao/Ax
that referenced
this pull request
Nov 27, 2024
Summary: Pull Request resolved: facebook#3112 Differential Revision: D66434621
ltiao
pushed a commit
to ltiao/Ax
that referenced
this pull request
Nov 27, 2024
Summary: Pull Request resolved: facebook#3112 Differential Revision: D66434621
ltiao
force-pushed
the
export-D66434621
branch
from
9027a1d to
fd76ff0
Compare
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Nov 27, 2024
Summary: Pull Request resolved: facebook#3112 Differential Revision: D66434621
|
This pull request was exported from Phabricator. Differential Revision: D66434621 |
ltiao
force-pushed
the
export-D66434621
branch
from
fd76ff0 to
e25946f
Compare
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Nov 28, 2024
Summary: Pull Request resolved: facebook#3112 Differential Revision: D66434621
|
This pull request was exported from Phabricator. Differential Revision: D66434621 |
ltiao
force-pushed
the
export-D66434621
branch
from
e25946f to
7f8f3b3
Compare
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Nov 28, 2024
Summary: Pull Request resolved: facebook#3112 Differential Revision: D66434621
|
This pull request was exported from Phabricator. Differential Revision: D66434621 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3112 +/- ##
=======================================
Coverage 95.98% 95.98%
=======================================
Files 539 539
Lines 52701 52735 +34
=======================================
+ Hits 50587 50620 +33
- Misses 2114 2115 +1 ☔ View full report in Codecov by Sentry. |
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Dec 4, 2024
Summary: * Provide a new method `latest` for `MapData` to retrieve the n most recently observed values for each (arm, metric) group, determined by the `map_key` values, where higher implies more recent. * Update `observations_from_data` to optionally utilize `latest` and retain only the most recently observed n values (the new option, if specified alongside the existing subsampling options, will now take precedence). * Revise the docstring to reflect changes in the pertinent methods, as well as update related methods like `subsample` to ensure uniform and consistent writing. * Modify the "upcast" df property to leverage `latest`, which is a special case with n=1. Differential Revision: D66434621
ltiao
force-pushed
the
export-D66434621
branch
from
7f8f3b3 to
0105f0e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66434621 |
ltiao
pushed a commit
to ltiao/Ax
that referenced
this pull request
Dec 4, 2024
Summary: Pull Request resolved: facebook#3112 Differential Revision: D66434621
ltiao
force-pushed
the
export-D66434621
branch
from
0105f0e to
1efcb42
Compare
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Dec 4, 2024
facebook#3112) Summary: * Provide a new method `latest` for `MapData` to retrieve the *n* most recently observed values for each (arm, metric) group, determined by the `map_key` values, where higher implies more recent. * Update `observations_from_data` to optionally utilize `latest` and retain only the most recently observed *n* values (the new option, if specified alongside the existing subsampling options, will now take precedence). * Modify the "upcast" `MapData.df` property to leverage `latest`, which is a special case with *n=1*. * Revise the docstring to reflect changes in the pertinent methods, as well as update related methods like `subsample` to ensure uniform and consistent writing. Differential Revision: D66434621
|
This pull request was exported from Phabricator. Differential Revision: D66434621 |
ltiao
pushed a commit
to ltiao/Ax
that referenced
this pull request
Dec 4, 2024
Summary: Pull Request resolved: facebook#3112 Differential Revision: D66434621
ltiao
pushed a commit
to ltiao/Ax
that referenced
this pull request
Dec 5, 2024
Summary: Pull Request resolved: facebook#3112 Differential Revision: D66434621
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Dec 9, 2024
facebook#3112) Summary: * Provide a new method `latest` for `MapData` to retrieve the *n* most recently observed values for each (arm, metric) group, determined by the `map_key` values, where higher implies more recent. * Update `observations_from_data` to optionally utilize `latest` and retain only the most recently observed *n* values (the new option, if specified alongside the existing subsampling options, will now take precedence). * Modify the "upcast" `MapData.df` property to leverage `latest`, which is a special case with *n=1*. * Revise the docstring to reflect changes in the pertinent methods, as well as update related methods like `subsample` to ensure uniform and consistent writing. Differential Revision: D66434621
ltiao
force-pushed
the
export-D66434621
branch
from
1efcb42 to
652714f
Compare
ltiao
pushed a commit
to ltiao/Ax
that referenced
this pull request
Dec 9, 2024
Summary: Pull Request resolved: facebook#3112 Differential Revision: D66434621
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Dec 9, 2024
facebook#3112) Summary: * Provide a new method `latest` for `MapData` to retrieve the *n* most recently observed values for each (arm, metric) group, determined by the `map_key` values, where higher implies more recent. * Update `observations_from_data` to optionally utilize `latest` and retain only the most recently observed *n* values (the new option, if specified alongside the existing subsampling options, will now take precedence). * Modify the "upcast" `MapData.df` property to leverage `latest`, which is a special case with *n=1*. * Revise the docstring to reflect changes in the pertinent methods, as well as update related methods like `subsample` to ensure uniform and consistent writing. Differential Revision: D66434621
ltiao
force-pushed
the
export-D66434621
branch
from
652714f to
4523b8a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66434621 |
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Dec 12, 2024
facebook#3112) Summary: Pull Request resolved: facebook#3112 * Provide a new method `latest` for `MapData` to retrieve the *n* most recently observed values for each (arm, metric) group, determined by the `map_key` values, where higher implies more recent. * Update `observations_from_data` to optionally utilize `latest` and retain only the most recently observed *n* values (the new option, if specified alongside the existing subsampling options, will now take precedence). * Modify the "upcast" `MapData.df` property to leverage `latest`, which is a special case with *n=1*. * Revise the docstring to reflect changes in the pertinent methods, as well as update related methods like `subsample` to ensure uniform and consistent writing. Differential Revision: D66434621
ltiao
force-pushed
the
export-D66434621
branch
from
4523b8a to
50896d4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66434621 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D66434621 |
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Dec 12, 2024
facebook#3112) Summary: Pull Request resolved: facebook#3112 * Provide a new method `latest` for `MapData` to retrieve the *n* most recently observed values for each (arm, metric) group, determined by the `map_key` values, where higher implies more recent. * Update `observations_from_data` to optionally utilize `latest` and retain only the most recently observed *n* values (the new option, if specified alongside the existing subsampling options, will now take precedence). * Modify the "upcast" `MapData.df` property to leverage `latest`, which is a special case with *n=1*. * Revise the docstring to reflect changes in the pertinent methods, as well as update related methods like `subsample` to ensure uniform and consistent writing. Differential Revision: D66434621
ltiao
force-pushed
the
export-D66434621
branch
from
50896d4 to
15d6240
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66434621 |
ltiao
force-pushed
the
export-D66434621
branch
from
15d6240 to
cad9e38
Compare
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Dec 12, 2024
facebook#3112) Summary: Pull Request resolved: facebook#3112 * Provide a new method `latest` for `MapData` to retrieve the *n* most recently observed values for each (arm, metric) group, determined by the `map_key` values, where higher implies more recent. * Update `observations_from_data` to optionally utilize `latest` and retain only the most recently observed *n* values (the new option, if specified alongside the existing subsampling options, will now take precedence). * Modify the "upcast" `MapData.df` property to leverage `latest`, which is a special case with *n=1*. * Revise the docstring to reflect changes in the pertinent methods, as well as update related methods like `subsample` to ensure uniform and consistent writing. Differential Revision: D66434621
ltiao
pushed a commit
to ltiao/Ax
that referenced
this pull request
Dec 17, 2024
…a, [Ax][WIP/Not Ready] Putting it all together (subclass TorchModelBridge) (facebook#3112) Summary: Pull Request resolved: facebook#3112 * Provide a new method `latest` for `MapData` to retrieve the *n* most recently observed values for each (arm, metric) group, determined by the `map_key` values, where higher implies more recent. * Update `observations_from_data` to optionally utilize `latest` and retain only the most recently observed *n* values (the new option, if specified alongside the existing subsampling options, will now take precedence). * Modify the "upcast" `MapData.df` property to leverage `latest`, which is a special case with *n=1*. * Revise the docstring to reflect changes in the pertinent methods, as well as update related methods like `subsample` to ensure uniform and consistent writing. Differential Revision: D66434621
|
This pull request was exported from Phabricator. Differential Revision: D66434621 |
ltiao
force-pushed
the
export-D66434621
branch
from
cad9e38 to
780ec32
Compare
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Feb 13, 2025
facebook#3112) Summary: Pull Request resolved: facebook#3112 **Context:** Early-stopping will lead to learning curves that are truncated at varying progressions/lengths, not necessarily just near the highest progressions or in the asymptotic regime. Incorporating one or more of the last seen values for curves that were stopped both early on during the stages of steepest descent and also those that were stopped in the asymptotic regime will likely provide useful/informative datapoints with which to improve the model This diff: * Provide a new method `latest` for `MapData` to retrieve the *n* most recently observed values for each (arm, metric) group, determined by the `map_key` values, where higher implies more recent. * Update `observations_from_data` to optionally utilize `latest` and retain only the most recently observed *n* values (the new option, if specified alongside the existing subsampling options, will now take precedence). * Modify the "upcast" `MapData.df` property to leverage `latest`, which is a special case with *n=1*. * Revise the docstring to reflect changes in the pertinent methods, as well as update related methods like `subsample` to ensure uniform and consistent writing. Reviewed By: esantorella Differential Revision: D66434621
|
This pull request was exported from Phabricator. Differential Revision: D66434621 |
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Feb 14, 2025
facebook#3112) Summary: Pull Request resolved: facebook#3112 **Context:** Early-stopping will lead to learning curves that are truncated at varying progressions/lengths, not necessarily just near the highest progressions or in the asymptotic regime. Incorporating one or more of the last seen values for curves that were stopped both early on during the stages of steepest descent and also those that were stopped in the asymptotic regime will likely provide useful/informative datapoints with which to improve the model This diff: * Provide a new method `latest` for `MapData` to retrieve the *n* most recently observed values for each (arm, metric) group, determined by the `map_key` values, where higher implies more recent. * Update `observations_from_data` to optionally utilize `latest` and retain only the most recently observed *n* values (the new option, if specified alongside the existing subsampling options, will now take precedence). * Modify the "upcast" `MapData.df` property to leverage `latest`, which is a special case with *n=1*. * Revise the docstring to reflect changes in the pertinent methods, as well as update related methods like `subsample` to ensure uniform and consistent writing. Reviewed By: esantorella Differential Revision: D66434621
ltiao
force-pushed
the
export-D66434621
branch
2 times, most recently
from
a20dca3 to
a529b8d
Compare
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Feb 19, 2025
facebook#3112) Summary: **Context:** Early-stopping will lead to learning curves that are truncated at varying progressions/lengths, not necessarily just near the highest progressions or in the asymptotic regime. Incorporating one or more of the last seen values for curves that were stopped both early on during the stages of steepest descent and also those that were stopped in the asymptotic regime will likely provide useful/informative datapoints with which to improve the model This diff: * Provide a new method `latest` for `MapData` to retrieve the *n* most recently observed values for each (arm, metric) group, determined by the `map_key` values, where higher implies more recent. * Update `observations_from_data` to optionally utilize `latest` and retain only the most recently observed *n* values (the new option, if specified alongside the existing subsampling options, will now take precedence). * Modify the "upcast" `MapData.df` property to leverage `latest`, which is a special case with *n=1*. * Revise the docstring to reflect changes in the pertinent methods, as well as update related methods like `subsample` to ensure uniform and consistent writing. Reviewed By: esantorella Differential Revision: D66434621
|
This pull request was exported from Phabricator. Differential Revision: D66434621 |
facebook#3112) Summary: **Context:** Early-stopping will lead to learning curves that are truncated at varying progressions/lengths, not necessarily just near the highest progressions or in the asymptotic regime. Incorporating one or more of the last seen values for curves that were stopped both early on during the stages of steepest descent and also those that were stopped in the asymptotic regime will likely provide useful/informative datapoints with which to improve the model This diff: * Provide a new method `latest` for `MapData` to retrieve the *n* most recently observed values for each (arm, metric) group, determined by the `map_key` values, where higher implies more recent. * Update `observations_from_data` to optionally utilize `latest` and retain only the most recently observed *n* values (the new option, if specified alongside the existing subsampling options, will now take precedence). * Modify the "upcast" `MapData.df` property to leverage `latest`, which is a special case with *n=1*. * Revise the docstring to reflect changes in the pertinent methods, as well as update related methods like `subsample` to ensure uniform and consistent writing. Reviewed By: esantorella Differential Revision: D66434621
ltiao
force-pushed
the
export-D66434621
branch
from
a529b8d to
0a1c81f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66434621 |
|
This pull request has been merged in 2a0d7a5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D66434621