Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only consider trials with data as target trial #3351

Closed
wants to merge 1 commit into from

Conversation

sdaulton
Copy link
Contributor

Summary: See title. This ensures the target trial is one with data.

Differential Revision: D69477011

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Feb 12, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69477011

sdaulton added a commit to sdaulton/Ax-1 that referenced this pull request Feb 12, 2025
Summary:

See title. This ensures the target trial is one with data.

Differential Revision: D69477011
@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 94.73684% with 3 lines in your changes missing coverage. Please review.

Project coverage is 95.72%. Comparing base (13ad726) to head (df05a4e).

Files with missing lines Patch % Lines
ax/utils/common/mock.py 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3351      +/-   ##
==========================================
- Coverage   95.73%   95.72%   -0.01%     
==========================================
  Files         534      534              
  Lines       52564    52591      +27     
==========================================
+ Hits        50320    50343      +23     
- Misses       2244     2248       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sdaulton added a commit to sdaulton/Ax-1 that referenced this pull request Feb 12, 2025
Summary:

See title. This ensures the target trial is one with data.

Differential Revision: D69477011
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69477011

sdaulton added a commit to sdaulton/Ax-1 that referenced this pull request Feb 12, 2025
Summary:

See title. This ensures the target trial is one with data.

Differential Revision: D69477011
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69477011

Summary:

See title. This ensures the target trial is one with data.

Reviewed By: mgarrard

Differential Revision: D69477011
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69477011

sdaulton added a commit to sdaulton/Ax-1 that referenced this pull request Feb 14, 2025
Summary:

See title. This ensures the target trial is one with data.

Reviewed By: mgarrard

Differential Revision: D69477011
sdaulton added a commit to sdaulton/Ax-1 that referenced this pull request Feb 14, 2025
Summary:

See title. This ensures the target trial is one with data.

Reviewed By: mgarrard

Differential Revision: D69477011
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 230920e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants