Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generation node string to base trial #3355

Closed

Conversation

bernardbeckerman
Copy link
Contributor

Summary: This will help expose the methods used to generate trials to the user, e.g., via experiment.to_df, matching legacy behavior in exp_to_df.

Reviewed By: saitcakmak

Differential Revision: D68909600

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Feb 12, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68909600

@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 96.42857% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.73%. Comparing base (f7227a2) to head (2404d94).

Files with missing lines Patch % Lines
ax/core/base_trial.py 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3355      +/-   ##
==========================================
- Coverage   95.73%   95.73%   -0.01%     
==========================================
  Files         534      534              
  Lines       52580    52603      +23     
==========================================
+ Hits        50336    50358      +22     
- Misses       2244     2245       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bernardbeckerman added a commit to bernardbeckerman/Ax that referenced this pull request Feb 12, 2025
Summary:

This will help expose the methods used to generate trials to the user, e.g., via experiment.to_df, matching legacy behavior in exp_to_df.

Reviewed By: saitcakmak

Differential Revision: D68909600
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68909600

bernardbeckerman added a commit to bernardbeckerman/Ax that referenced this pull request Feb 12, 2025
Summary:
Pull Request resolved: facebook#3355

This will help expose the methods used to generate trials to the user, e.g., via experiment.to_df, matching legacy behavior in exp_to_df.

Differential Revision: D68909600

Reviewed By: saitcakmak
bernardbeckerman added a commit to bernardbeckerman/Ax that referenced this pull request Feb 13, 2025
Summary:
Pull Request resolved: facebook#3355

This will help expose the methods used to generate trials to the user, e.g., via experiment.to_df, matching legacy behavior in exp_to_df.

Differential Revision: D68909600

Reviewed By: saitcakmak
bernardbeckerman added a commit to bernardbeckerman/Ax that referenced this pull request Feb 13, 2025
Summary:
Pull Request resolved: facebook#3355

This will help expose the methods used to generate trials to the user, e.g., via experiment.to_df, matching legacy behavior in exp_to_df.

Differential Revision: D68909600

Reviewed By: saitcakmak
bernardbeckerman added a commit to bernardbeckerman/Ax that referenced this pull request Feb 13, 2025
Summary:

This will help expose the methods used to generate trials to the user, e.g., via experiment.to_df, matching legacy behavior in exp_to_df.

Reviewed By: saitcakmak

Differential Revision: D68909600
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68909600

bernardbeckerman added a commit to bernardbeckerman/Ax that referenced this pull request Feb 13, 2025
Summary:
Pull Request resolved: facebook#3355

This will help expose the methods used to generate trials to the user, e.g., via experiment.to_df, matching legacy behavior in exp_to_df.

Differential Revision: D68909600

Reviewed By: saitcakmak
bernardbeckerman added a commit to bernardbeckerman/Ax that referenced this pull request Feb 13, 2025
Summary:
Pull Request resolved: facebook#3355

This will help expose the methods used to generate trials to the user, e.g., via experiment.to_df, matching legacy behavior in exp_to_df.

Differential Revision: D68909600

Reviewed By: saitcakmak
Summary:

This will help expose the methods used to generate trials to the user, e.g., via experiment.to_df, matching legacy behavior in exp_to_df.

Reviewed By: saitcakmak

Differential Revision: D68909600
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68909600

bernardbeckerman added a commit to bernardbeckerman/Ax that referenced this pull request Feb 13, 2025
Summary:
Pull Request resolved: facebook#3355

This will help expose the methods used to generate trials to the user, e.g., via experiment.to_df, matching legacy behavior in exp_to_df.

Differential Revision: D68909600

Reviewed By: saitcakmak
bernardbeckerman added a commit to bernardbeckerman/Ax that referenced this pull request Feb 13, 2025
Summary:
Pull Request resolved: facebook#3355

This will help expose the methods used to generate trials to the user, e.g., via experiment.to_df, matching legacy behavior in exp_to_df.

Differential Revision: D68909600

Reviewed By: saitcakmak
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 6070046.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants