Clean up multi-surrogate utilities #3370
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Removes some used utilities that were originally introduced to ensure correct dataset splitting between multiple surrogates. Multiple surrogate support has since been deprecated and these are not needed. Reviewed By: sdaulton Differential Revision: D69632792
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D69632792 |
saitcakmak
added a commit
to saitcakmak/Ax
that referenced
this pull request
Feb 14, 2025
Summary: Removes some used utilities that were originally introduced to ensure correct dataset splitting between multiple surrogates. Multiple surrogate support has since been deprecated and these are not needed. Reviewed By: sdaulton Differential Revision: D69632792
saitcakmak
added a commit
to saitcakmak/Ax
that referenced
this pull request
Feb 14, 2025
Summary: Removes some used utilities that were originally introduced to ensure correct dataset splitting between multiple surrogates. Multiple surrogate support has since been deprecated and these are not needed. Reviewed By: sdaulton Differential Revision: D69632792
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3370 +/- ##
==========================================
- Coverage 95.73% 95.73% -0.01%
==========================================
Files 538 538
Lines 52660 52579 -81
==========================================
- Hits 50415 50334 -81
Misses 2245 2245 ☔ View full report in Codecov by Sentry. |
saitcakmak
added a commit
to saitcakmak/Ax
that referenced
this pull request
Feb 14, 2025
Summary: Removes some used utilities that were originally introduced to ensure correct dataset splitting between multiple surrogates. Multiple surrogate support has since been deprecated and these are not needed. Reviewed By: sdaulton Differential Revision: D69632792
saitcakmak
added a commit
to saitcakmak/Ax
that referenced
this pull request
Feb 14, 2025
Summary: Removes some used utilities that were originally introduced to ensure correct dataset splitting between multiple surrogates. Multiple surrogate support has since been deprecated and these are not needed. Reviewed By: sdaulton Differential Revision: D69632792
|
This pull request has been merged in b65320d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Removes some used utilities that were originally introduced to ensure correct dataset splitting between multiple surrogates. Multiple surrogate support has since been deprecated and these are not needed.
Reviewed By: sdaulton
Differential Revision: D69632792