Add black "x"s at sampled x coordinates in slice plot #3405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D69988707 |
mpolson64
force-pushed
the
export-D69988707
branch
from
7a378ac to
d82564b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69988707 |
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Feb 21, 2025
Summary: As titled. These are moderately useful here, but I really want to add them to the contour plot and I want the slice plot to match since theyre often displayed together. Differential Revision: D69988707
mpolson64
force-pushed
the
export-D69988707
branch
from
d82564b to
23509c6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69988707 |
mpolson64
force-pushed
the
export-D69988707
branch
from
23509c6 to
a8aa028
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69988707 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3405 +/- ##
=======================================
Coverage 95.98% 95.99%
=======================================
Files 539 539
Lines 52788 52801 +13
=======================================
+ Hits 50671 50684 +13
Misses 2117 2117 ☔ View full report in Codecov by Sentry. |
Summary: As titled. These are moderately useful here, but I really want to add them to the contour plot and I want the slice plot to match since theyre often displayed together. Differential Revision: D69988707
mpolson64
force-pushed
the
export-D69988707
branch
from
a8aa028 to
c19ddbb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69988707 |
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Feb 24, 2025
Summary: As titled. These are moderately useful here, but I really want to add them to the contour plot and I want the slice plot to match since theyre often displayed together. Differential Revision: D69988707
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: As titled. These are moderately useful here, but I really want to add them to the contour plot and I want the slice plot to match since theyre often displayed together.
Differential Revision: D69988707