Add category to AnalysisCards #3414
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3414 +/- ##
=======================================
Coverage 95.98% 95.99%
=======================================
Files 539 539
Lines 52791 52819 +28
=======================================
+ Hits 50674 50702 +28
Misses 2117 2117 ☔ View full report in Codecov by Sentry. |
|
This pull request was exported from Phabricator. Differential Revision: D69726341 |
|
This pull request was exported from Phabricator. Differential Revision: D69726341 |
mgarrard
force-pushed
the
export-D69726341
branch
from
4a5e0bb to
d38a4e6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69726341 |
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Feb 24, 2025
Summary: Pull Request resolved: facebook#3414 We've had a few instances come up in meetings last week that I think will make having a category useful: 1. Allow us to group similar analysis together in the UI so everything isn't shown in one tab 2. Allow for easy grouping of analysis in bento notebooks Additionally, as I was implementing this, there is a TODO on base_client to find a good hueristic for which analysis to show, I think implementing that hueristic will be much easier with category. I think this is useful enough to warrant the addition because it is distinct from level- which indicates importance - and category should still be ranked by level. Reviewed By: mpolson64, Cesar-Cardoso Differential Revision: D69726341
mgarrard
force-pushed
the
export-D69726341
branch
from
d38a4e6 to
1e33d1f
Compare
Summary: Pull Request resolved: facebook#3414 We've had a few instances come up in meetings last week that I think will make having a category useful: 1. Allow us to group similar analysis together in the UI so everything isn't shown in one tab 2. Allow for easy grouping of analysis in bento notebooks Additionally, as I was implementing this, there is a TODO on base_client to find a good hueristic for which analysis to show, I think implementing that hueristic will be much easier with category. I think this is useful enough to warrant the addition because it is distinct from level- which indicates importance - and category should still be ranked by level. Reviewed By: mpolson64, Cesar-Cardoso Differential Revision: D69726341
|
This pull request was exported from Phabricator. Differential Revision: D69726341 |
mgarrard
force-pushed
the
export-D69726341
branch
from
1e33d1f to
035d3f0
Compare
|
This pull request has been merged in 2339fb0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We've had a few instances come up in meetings last week that I think will make having a category useful:
Additionally, as I was implementing this, there is a TODO on base_client to find a good hueristic for which analysis to show, I think implementing that hueristic will be much easier with category.
I think this is useful enough to warrant the addition because it is distinct from level- which indicates importance - and category should still be ranked by level.
Reviewed By: mpolson64, Cesar-Cardoso
Differential Revision: D69726341