Improve readability of CV plot #3426
Closed
+183
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D70195847 |
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Feb 27, 2025
Summary: In the previous diff we exposed an adhoc comput method for CV, but the delta between the previous plot and our new plot is a degragation in UX. This diff fixes that by: - tightening the autozoom - making the points more transparent so they are more visible individually - improving the hover - adding x and y axis titles Thanks for pointing some of these out Sam! Differential Revision: D70195847
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3426 +/- ##
==========================================
- Coverage 95.99% 95.99% -0.01%
==========================================
Files 539 539
Lines 52850 52850
==========================================
- Hits 50735 50734 -1
- Misses 2115 2116 +1 ☔ View full report in Codecov by Sentry. |
mgarrard
force-pushed
the
export-D70195847
branch
from
0a497cb to
aecd687
Compare
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Feb 27, 2025
Summary: In the previous diff we exposed an adhoc comput method for CV, but the delta between the previous plot and our new plot is a degragation in UX. This diff fixes that by: - tightening the autozoom - making the points more transparent so they are more visible individually - improving the hover - adding x and y axis titles Thanks for pointing some of these out Sam! Differential Revision: D70195847
|
This pull request was exported from Phabricator. Differential Revision: D70195847 |
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Feb 27, 2025
Summary: Pull Request resolved: facebook#3426 In the previous diff we exposed an adhoc comput method for CV, but the delta between the previous plot and our new plot is a degragation in UX. This diff fixes that by: - tightening the autozoom - making the points more transparent so they are more visible individually - improving the hover - adding x and y axis titles Thanks for pointing some of these out Sam! Differential Revision: D70195847
mgarrard
force-pushed
the
export-D70195847
branch
2 times, most recently
from
fdee121 to
0146b8f
Compare
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Feb 27, 2025
Summary: In the previous diff we exposed an adhoc comput method for CV, but the delta between the previous plot and our new plot is a degragation in UX. This diff fixes that by: - tightening the autozoom - making the points more transparent so they are more visible individually - improving the hover - adding x and y axis titles Thanks for pointing some of these out Sam! Differential Revision: D70195847
|
This pull request was exported from Phabricator. Differential Revision: D70195847 |
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Feb 27, 2025
Summary: In the previous diff we exposed an adhoc comput method for CV, but the delta between the previous plot and our new plot is a degragation in UX. This diff fixes that by: - tightening the autozoom - making the points more transparent so they are more visible individually - improving the hover - adding x and y axis titles Thanks for pointing some of these out Sam! Differential Revision: D70195847
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Feb 27, 2025
Summary: In the previous diff we exposed an adhoc comput method for CV, but the delta between the previous plot and our new plot is a degragation in UX. This diff fixes that by: - tightening the autozoom - making the points more transparent so they are more visible individually - improving the hover - adding x and y axis titles Thanks for pointing some of these out Sam! Differential Revision: D70195847
mgarrard
force-pushed
the
export-D70195847
branch
from
0146b8f to
f622d40
Compare
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Feb 27, 2025
Summary: In the previous diff we exposed an adhoc comput method for CV, but the delta between the previous plot and our new plot is a degragation in UX. This diff fixes that by: - tightening the autozoom - making the points more transparent so they are more visible individually - improving the hover - adding x and y axis titles Thanks for pointing some of these out Sam! Reviewed By: mpolson64 Differential Revision: D70195847
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Feb 27, 2025
Summary: In the previous diff we exposed an adhoc comput method for CV, but the delta between the previous plot and our new plot is a degragation in UX. This diff fixes that by: - tightening the autozoom - making the points more transparent so they are more visible individually - improving the hover - adding x and y axis titles Thanks for pointing some of these out Sam! Reviewed By: mpolson64 Differential Revision: D70195847
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Feb 27, 2025
Summary: In the previous diff we exposed an adhoc comput method for CV, but the delta between the previous plot and our new plot is a degragation in UX. This diff fixes that by: - tightening the autozoom - making the points more transparent so they are more visible individually - improving the hover - adding x and y axis titles Thanks for pointing some of these out Sam! Reviewed By: mpolson64 Differential Revision: D70195847
|
This pull request was exported from Phabricator. Differential Revision: D70195847 |
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Feb 27, 2025
Summary: Pull Request resolved: facebook#3426 In the previous diff we exposed an adhoc comput method for CV, but the delta between the previous plot and our new plot is a degragation in UX. This diff fixes that by: - tightening the autozoom - making the points more transparent so they are more visible individually - improving the hover - adding x and y axis titles Thanks for pointing some of these out Sam! Reviewed By: mpolson64 Differential Revision: D70195847
mgarrard
force-pushed
the
export-D70195847
branch
from
f622d40 to
fdd7c4c
Compare
added 2 commits
February 27, 2025 16:24
…hing breaks if we update analysis_Base, Temporary Commit at 2/25/2025, 1:16:09 PM Summary: .... Differential Revision: D69725960
…ked changes) Differential Revision: D69754828
mgarrard
force-pushed
the
export-D70195847
branch
from
fdd7c4c to
901d63c
Compare
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Feb 28, 2025
Summary: In the previous diff we exposed an adhoc comput method for CV, but the delta between the previous plot and our new plot is a degragation in UX. This diff fixes that by: - tightening the autozoom - making the points more transparent so they are more visible individually - improving the hover - adding x and y axis titles Thanks for pointing some of these out Sam! Reviewed By: mpolson64 Differential Revision: D70195847
Summary: Pull Request resolved: facebook#3426 In the previous diff we exposed an adhoc comput method for CV, but the delta between the previous plot and our new plot is a degragation in UX. This diff fixes that by: - tightening the autozoom - making the points more transparent so they are more visible individually - improving the hover - adding x and y axis titles Thanks for pointing some of these out Sam! Reviewed By: mpolson64 Differential Revision: D70195847
|
This pull request was exported from Phabricator. Differential Revision: D70195847 |
mgarrard
force-pushed
the
export-D70195847
branch
from
901d63c to
4898b8b
Compare
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Feb 28, 2025
Summary: In the previous diff we exposed an adhoc comput method for CV, but the delta between the previous plot and our new plot is a degragation in UX. This diff fixes that by: - tightening the autozoom - making the points more transparent so they are more visible individually - improving the hover - adding x and y axis titles Thanks for pointing some of these out Sam! Reviewed By: mpolson64 Differential Revision: D70195847
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Mar 1, 2025
Summary: In the previous diff we exposed an adhoc comput method for CV, but the delta between the previous plot and our new plot is a degragation in UX. This diff fixes that by: - tightening the autozoom - making the points more transparent so they are more visible individually - improving the hover - adding x and y axis titles Thanks for pointing some of these out Sam! Reviewed By: mpolson64 Differential Revision: D70195847
|
This pull request has been merged in d6b5f53. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In the previous diff we exposed an adhoc comput method for CV, but the delta between the previous plot and our new plot is a degragation in UX. This diff fixes that by:
Thanks for pointing some of these out Sam!
Differential Revision: D70195847