remove unnecessary data validation for trial index #3433
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D70301660 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3433 +/- ##
=======================================
Coverage 95.99% 95.99%
=======================================
Files 539 539
Lines 52850 52860 +10
=======================================
+ Hits 50735 50745 +10
Misses 2115 2115 ☔ View full report in Codecov by Sentry. |
added 4 commits
February 27, 2025 10:52
…hing breaks if we update analysis_Base, Temporary Commit at 2/25/2025, 1:16:09 PM Summary: .... Differential Revision: D69725960
…ked changes) Differential Revision: D69754828
Summary: In the previous diff we exposed an adhoc comput method for CV, but the delta between the previous plot and our new plot is a degragation in UX. This diff fixes that by: - tightening the autozoom - making the points more transparent so they are more visible individually - improving the hover - adding x and y axis titles Thanks for pointing some of these out Sam! Differential Revision: D70195847
Summary: This is the second ux improvement diff for adhoc cross validation computation. This allows for mulitple metrics to be computed at one time for a single adapter. It does not currently tile or drop down the metic names. This is a nice improvement we'd like to make, but it wasn't immediately clear how to go about this Differential Revision: D70200056
mgarrard
force-pushed
the
export-D70301660
branch
from
2b5f81f to
c886c6e
Compare
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Feb 27, 2025
Summary: previously in this diff stack we realized that this check is actually not that helpful, we remove it here. Frankly, I don't fully understand how trial_index is being leveraged so could be helpful to get some UI ptrs for that Differential Revision: D70301660
Summary: Pull Request resolved: facebook#3433 previously in this diff stack we realized that this check is actually not that helpful, we remove it here. Frankly, I don't fully understand how trial_index is being leveraged so could be helpful to get some UI ptrs for that Differential Revision: D70301660
|
This pull request was exported from Phabricator. Differential Revision: D70301660 |
mgarrard
force-pushed
the
export-D70301660
branch
from
c886c6e to
de94c9d
Compare
|
This pull request has been merged in 1b22d05. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
previously in this diff stack we realized that this check is actually not that helpful, we remove it here.
Frankly, I don't fully understand how trial_index is being leveraged so could be helpful to get some UI ptrs for that
Differential Revision: D70301660