Improve ergonomics around early stopping #3446
Open
+87
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D70397779 |
|
This pull request was exported from Phabricator. Differential Revision: D70397779 |
mpolson64
force-pushed
the
export-D70397779
branch
from
e433d8b to
77e336a
Compare
Summary: As discussed in Ax/Botorch sync. mark_trial_early_stopped signuture is brought in line with other mark_trial_STATUS methods and BaseTrial now validates that data must be present on a trial when marking it early stopped. This Exception from BaseTrial is a ValueError to stay in line with convention in that module, but is wrapped in an Ax UnsupportedError in Client where we expect exceptions to be Ax classes. Reviewed By: lena-kashtelyan Differential Revision: D70397779
mpolson64
force-pushed
the
export-D70397779
branch
from
77e336a to
8d94b24
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70397779 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3446 +/- ##
==========================================
- Coverage 96.00% 96.00% -0.01%
==========================================
Files 539 539
Lines 52933 52945 +12
==========================================
+ Hits 50819 50829 +10
- Misses 2114 2116 +2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: As discussed in Ax/Botorch sync. mark_trial_early_stopped signuture is brought in line with other mark_trial_STATUS methods and BaseTrial now validates that data must be present on a trial when marking it early stopped. This Exception from BaseTrial is a ValueError to stay in line with convention in that module, but is wrapped in an Ax UnsupportedError in Client where we expect exceptions to be Ax classes.
Reviewed By: lena-kashtelyan
Differential Revision: D70397779