Tags: facebook/Ax
Tags
Remove hypothesis dependency (#2774) Summary: Pull Request resolved: #2774 Context: Hypothesis is not commonly used in Ax and is not part of the `UNITTEST_MINIMAL_REQUIRES` dependencies (although it is part of `UNITTEST_REQUIRES`). It is used in only one benchmarking test. Removing it will make it easier to build an environment that can run benchmark tests. We could have a broader discussion about removing it from Ax entirely. This diff: Changes a unit test to not use hypothesis Reviewed By: saitcakmak Differential Revision: D63150787 fbshipit-source-id: daf732bb9effc45406816610f0d95f547d5ab192
Don't test with a test stub when there's a function that does the sam… …e thing (#2735) Summary: Pull Request resolved: #2735 Context: * There is a `get_sobol_benchmark_method` test stub, which is not needed when a Sobol benchmark method is provided, also called `get_sobol_benchmark_method`. It is better to test that function. * The latter `get_sobol_benchmark_method` requires an argument `distribute_replications`. (Making this mandatory was an intentional choice, because it is easy to forget it.) This diff: * Gets rid of the test stub and uses the non-stub version instead * Adds `distribute_replications` in a bunch of places. I chose `False` arbitrarily since the argument will have no effect here. Reviewed By: saitcakmak Differential Revision: D62157106 fbshipit-source-id: 9d6ef4e609502fc94d09be31aa31b1dd7325b111
Update GenerationNode.model_to_gen_from_name (#2407) Summary: Pull Request resolved: #2407 Updates the behavior to match the docstring. Previously, this would call `model_spec_to_gen_from`, which could lead to fitting multiple models if the node had multiple model specs. The return type was always `str` rather than `Optional[str]` suggested by the type hints. Reviewed By: mgarrard Differential Revision: D56735619 fbshipit-source-id: a6b39b3bc921f720bcb43daece55dc9da1ee96c6
Fix breaking "fix lint" github signal Summary: "fix lint" signal is failing on github https://github.com/facebook/Ax/actions/runs/8090412501/job/22107860418#step:6:13 ``` Run flake8 flake8 shell: /usr/bin/bash -e {0} env: pythonLocation: /opt/hostedtoolcache/Python/3.9.18/x64 PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.9.18/x64/lib/pkgconfig Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.9.18/x64 Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.9.18/x64 Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.9.18/x64 LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.9.18/x64/lib ./ax/models/torch/tests/test_model.py:8:1: F401 'warnings' imported but unused Error: Process completed with exit code 1. ``` Fixing to unbreak Reviewed By: mpolson64 Differential Revision: D54370344 fbshipit-source-id: bc69cb1641170eb8e79588692b77da13b8dc67e2
Fix error in `make_tutorials.py` (#2066) Summary: If `env` is `None` then this raises a `'NoneType' object has no attribute 'items'` error. This change fixes this issue and simplifies the setup. Pull Request resolved: #2066 Reviewed By: mgarrard Differential Revision: D52007186 Pulled By: Balandat fbshipit-source-id: 7744a7391381fe6a298d7c7d43bb5d42c982dd28
PreviousNext