Use sudo for make benchmark if current user is not root
#199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename the create-images step from "Build container" to image, so this
step and the name one ("Build") are easy to distinguish in the GitHub PR
UI.
qdeslandes
force-pushed
the
benchmark_commit_summary
branch
from
3adb489 to
4c37a56
Compare
Add a custom script to prefix the benchmark run command with sudo if the current user is not root. This change will fix the benchmark run in the CI (by not using sudo) while not breaking the local build (as sudo will be used).
qdeslandes
force-pushed
the
benchmark_commit_summary
branch
from
c141483 to
9fbfea6
Compare
qdeslandes
changed the title
sudo for make benchmark if current user is not root
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
sudofor the benchmark run if the current user is not root, otherwise run as-is. This is expected to solve the CI build failure as the container waits for a password to be provided with sudo.