Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme): light & dark mode checkbox doesn't announce state switches #10585

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

andrewasche
Copy link
Contributor

@andrewasche andrewasche commented Oct 16, 2024

Pre-flight checklist

  • [X ] I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Test Plan

yarn start
open webpage and use nvda to test that the aria-pressed is saying if the button is pressed or if the button is not pressed

Test links

https://deploy-preview-10585--docusaurus-2.netlify.app/

@facebook-github-bot
Copy link
Contributor

Hi @andrewasche!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Copy link

netlify bot commented Oct 16, 2024

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 9a5f81a
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/671139119fcfb600085580d4
😎 Deploy Preview https://deploy-preview-10585--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Oct 16, 2024

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO Report
/ 🟠 80 🟢 98 🟢 96 🟢 100 Report
/docs/installation 🟠 58 🟢 97 🟢 100 🟢 100 Report
/docs/category/getting-started 🟠 73 🟢 100 🟢 100 🟠 86 Report
/blog 🟠 63 🟢 96 🟢 100 🟠 86 Report
/blog/preparing-your-site-for-docusaurus-v3 🔴 48 🟢 92 🟢 100 🟢 100 Report
/blog/tags/release 🟠 63 🟢 96 🟢 100 🟠 86 Report
/blog/tags 🟠 74 🟢 100 🟢 100 🟠 86 Report

@andrewasche
Copy link
Contributor Author

I have completed the Contributor License Agreement after the workflow run into that issue. I couldn't figure out dogfooding either.

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Oct 16, 2024
@slorber slorber changed the title fix: light & dark mode checkbox doesn't announce state switches fix(theme): light & dark mode checkbox doesn't announce state switches Oct 18, 2024
@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Oct 18, 2024
@slorber
Copy link
Collaborator

slorber commented Oct 18, 2024

LGTM thanks

Apparently it's not really "needed" considering the aria-label is dynamic, but it also doesn't harm so let's merge it

@slorber slorber merged commit 9457833 into facebook:main Oct 18, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants