chore: enable nx as task runner for lerna #8573
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AgentEnder
requested review from
slorber,
lex111 and
Josh-Cena
as code owners
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
slorber
reviewed
Jan 26, 2023
AgentEnder
force-pushed
the
chore/enable-nx
branch
from
5d99ce0
to
61b07b4
Compare
|
Hey @slorber! It's hard to believe its taken so long to come back to this, and for that I apologize. Nonetheless, the PR should be good to go now if you are able to take another look. Let me know if there is anything else I can do - next steps for this repo would be to start setting up caching for local dev, and then finally getting the remote cache setup with nx-cloud (which is free for OSS) |
AgentEnder
force-pushed
the
chore/enable-nx
branch
from
61b07b4
to
b9e2394
Compare
|
Thanks, I'll check this out after v3 is out because I'd prefer to focus on that for now ;) |
|
Yep, no worries. Thanks for the patience on this one @slorber 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
Motivation
Follows from #8447. Another follow up PR will finally enable caching 😄
Test Plan
Nothing should change, dev tooling dependency upgrade only.
Test links
Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/
Related issues/PRs
#8318
#8447
fix #7333