Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix grammatical error, rewrite sentence to make clearer #9223

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

thatrobotdev
Copy link
Contributor

@thatrobotdev thatrobotdev commented Aug 13, 2023

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

I was reading through this page and noticed a minor grammatical error. The semicolon between "instead of depending on a released version" and "your contributors can also conveniently update the docs as they implement features" is grammatically incorrect because the two clauses are not independent. This rewrites the sentence to be more clear without the grammatical error.

Test Plan

No code changed, so not tested on local device.

Test links

Current docs:
https://docusaurus.io/docs/installation#monorepos

Deploy preview: https://deploy-preview-9223--docusaurus-2.netlify.app/docs/installation/#monorepos

The semicolon between "instead of depending on a released version" and "your contributors can also conveniently update the docs as they implement features" is grammatically incorrect because the two clauses are not independent. This rewrites the sentence to be more clear without the grammatical error.
@netlify
Copy link

netlify bot commented Aug 13, 2023

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit c83be0e
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/64d8eed35f7597000844cf0f
😎 Deploy Preview https://deploy-preview-9223--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 65 🟢 97 🟢 92 🟢 100 🔴 33 Report
/docs/installation 🟠 75 🟢 98 🟢 92 🟢 100 🟠 89 Report

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Aug 17, 2023
@slorber slorber merged commit 67c4006 into facebook:main Aug 17, 2023
8 checks passed
@thatrobotdev thatrobotdev deleted the thatrobotdev-patch-1 branch August 17, 2023 12:45
This was referenced Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants