Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme-common): remove useless useSyncExternalStore shim #9276

Merged
merged 4 commits into from
Sep 4, 2023

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Sep 4, 2023

Motivation

Follow-up of #8961

With React 18, the useSyncExternalStore shim is not necessary anymore.

I forgot to remove it in the React 18 PR, which can lead to some conflict errors during SSR on sites upgrading to v3.

Test Plan

CI

Test links

Deploy preview: https://deploy-preview-9276--docusaurus-2.netlify.app/

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Sep 4, 2023
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Sep 4, 2023
@netlify
Copy link

netlify bot commented Sep 4, 2023

[V2]

Name Link
🔨 Latest commit a4789b2
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/64f5e3428b91970008d19182
😎 Deploy Preview https://deploy-preview-9276--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Sep 4, 2023

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 58 🟢 97 🟢 92 🟢 100 🟠 89 Report
/docs/installation 🟠 69 🟢 98 🟢 92 🟢 100 🟠 89 Report

@slorber slorber added the Argos Add this label to run UI visual regression tests. See argos.yml GH action. label Sep 4, 2023
@github-actions
Copy link

github-actions bot commented Sep 4, 2023

Size Change: -825 B (0%)

Total Size: 1.11 MB

Filename Size Change
website/build/assets/js/main.********.js 836 kB -825 B (0%)
ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 117 kB
website/build/assets/css/styles.********.css 113 kB
website/build/index.html 41.4 kB

compressed-size-action

@argos-ci
Copy link

argos-ci bot commented Sep 4, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No change detected - Sep 4, 2023, 2:13 PM

@slorber slorber changed the title fix: remove useless useSyncExternalStore shim fix(theme-common): remove useless useSyncExternalStore shim Sep 4, 2023
@slorber slorber merged commit 97d5dd0 into main Sep 4, 2023
28 of 29 checks passed
@slorber slorber deleted the slorber/remove-useSyncExternalStore-shim branch September 4, 2023 14:22
This was referenced Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Argos Add this label to run UI visual regression tests. See argos.yml GH action. CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants