[minipack3n] Fix LED Mapping: Rename MCB_LED_PORT_66_LED_1 to _65_LED_2 #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) The original pmUnitScopedName "MCB_LED_PORT_66_LED_1" was incorrect.
2) The correct port LED mapping corresponds to port-65-led-2.
3) Renamed MCB_LED_PORT_66_LED_1 to MCB_LED_PORT_65_LED_2 to reflect the correct mapping.
1) Run platform_manager with the updated configuration.
2) Verify that the correct sysfs files are created:
ls /sys/class/leds/port65_led2\:*
Test Log: [20250306_Port65_Led2_Test.txt](https://github.com/user-attachments/files/19104721/20250306_Port65_Led2_Test.txt)
3) Execute Port65_Led2_Test.py to ensure the LED color changes as expected.
Test Log: [Port65_Led2_Test.py.txt](https://github.com/user-attachments/files/19104799/Port65_Led2_Test.py.txt)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Test Plan:
ls /sys/class/leds/port65_led2:*
Test Log: 20250306_Port65_Led2_Test.txt
Test Log: Port65_Led2_Test.py.txt