Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix -Winconsistent-override in MysqlConnectPoolOperationImpl
Summary: clang 19 reports -Winconsistent-override for this header: ``` hhvm/third-party/squangle/src/squangle/mysql_client/mysql_protocol/MysqlConnectPoolOperationImpl.h:132:8: warning: 'connectionCallback' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] 132 | void connectionCallback( | ^ hhvm/third-party/squangle/src/squangle/mysql_client/SyncConnectionPool.cpp:62:13: note: in instantiation of template class 'facebook::common::mysql_client::mysql_protocol::MysqlConnectPoolOperationImpl<facebook::common::mysql_client::SyncMysqlClient>' requested here 62 | std::string SyncConnectPoolOperationImpl::createTimeoutErrorMessage( | ^ hhvm/third-party/squangle/src/squangle/mysql_client/ConnectPoolOperation.h:42:16: note: overridden virtual function is here 42 | virtual void connectionCallback( | ^ 1 warning generated. ``` X-link: facebook/squangle#19 Reviewed By: fadimounir Differential Revision: D69474852 Pulled By: jkedgar fbshipit-source-id: 92731aa1da77cacaf188adc971defcb52eebfdd9
- Loading branch information