Skip to content

Commit

Permalink
Fix -Winconsistent-override in MysqlConnectPoolOperationImpl
Browse files Browse the repository at this point in the history
Summary:
clang 19 reports -Winconsistent-override for this header:
```
hhvm/third-party/squangle/src/squangle/mysql_client/mysql_protocol/MysqlConnectPoolOperationImpl.h:132:8: warning: 'connectionCallback' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
  132 |   void connectionCallback(
      |        ^
hhvm/third-party/squangle/src/squangle/mysql_client/SyncConnectionPool.cpp:62:13: note: in instantiation of template class 'facebook::common::mysql_client::mysql_protocol::MysqlConnectPoolOperationImpl<facebook::common::mysql_client::SyncMysqlClient>' requested here
   62 | std::string SyncConnectPoolOperationImpl::createTimeoutErrorMessage(
      |             ^
hhvm/third-party/squangle/src/squangle/mysql_client/ConnectPoolOperation.h:42:16: note: overridden virtual function is here
   42 |   virtual void connectionCallback(
      |                ^
1 warning generated.
```

X-link: facebook/squangle#19

Reviewed By: fadimounir

Differential Revision: D69474852

Pulled By: jkedgar

fbshipit-source-id: 92731aa1da77cacaf188adc971defcb52eebfdd9
  • Loading branch information
mszabo-wikia authored and facebook-github-bot committed Feb 12, 2025
1 parent 420b668 commit e115e30
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ class MysqlConnectPoolOperationImpl : public MysqlConnectOperationImpl,

// Called when the connection is matched by the pool client
void connectionCallback(
std::unique_ptr<MysqlPooledHolder<Client>> pooled_conn) {
std::unique_ptr<MysqlPooledHolder<Client>> pooled_conn) override {
// TODO: validate we are in the correct thread (for async)

if (!pooled_conn) {
Expand Down

0 comments on commit e115e30

Please sign in to comment.