[lexical-table] Support first column freeze #7134
Conversation
ivailop7
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz,
Sahejkm and
potatowagon
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
There was a problem hiding this comment.
Seems to work well! I think a number is a bit more future-proof than a boolean (the accessor could be a boolean for now, mostly just thinking about the JSON). I did notice a typo but otherwise this looks good. I only tested in Chrome though, Safari and Firefox might have CSS quirks with this sort of thing?
| @@ -48,6 +48,7 @@ export type SerializedTableNode = Spread< | |||
| { | |||
| colWidths?: readonly number[]; | |||
| rowStriping?: boolean; | |||
| frozenFirstColumn?: boolean; | |||
There was a problem hiding this comment.
For what it's worth, the Google Sheets API uses a frozenRowCount and frozenColumnCount. Freezing the first n rows or columns is probably not much harder than freezing one? Even if we only support 1 right now we could still future-proof the JSON by using a number.
https://developers.google.com/sheets/api/reference/rest/v4/spreadsheets/sheets
There was a problem hiding this comment.
This is a fantastic suggestion. I'll do it this way.
|
@etrepum this one is good to go |
|
Oh, my oversight. I'll add the export JSON and add an extra test. |
Part one of freeze support in tables.
Have done the easier part, freezing a column
Screen.Recording.2025-02-09.at.17.28.34.mov