Skip to content

Commit

Permalink
remove layout data check to unbreak Litho layout caching
Browse files Browse the repository at this point in the history
Summary:
Litho makes assumptions around layout data that are not completely correct. Unfortunately the layout data check in `MountState` breaks Litho's layout caching. I'm reverting the check to unblock experiments on layout caching. We'll reland the check with more soak time to ensure that we catch any layout caching issues in Litho.

I'll try and get a pick for this between today and tomorrow

Reviewed By: pentiumao

Differential Revision: D50702380

fbshipit-source-id: e080e032d01097c864d4f23141a7a4c33207ad57
  • Loading branch information
Daniel Famakin authored and facebook-github-bot committed Oct 26, 2023
1 parent e83d15c commit 88ea915
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -1038,7 +1038,7 @@ private void updateMountItemIfNeeded(RenderTreeNode renderTreeNode, MountItem cu
mountDelegate.startNotifyVisibleBoundsChangedSection();
}

if (currentRenderUnit != renderUnit || currentLayoutData != newLayoutData) {
if (currentRenderUnit != renderUnit) {
Integer traceIdentifier = generateTraceIdentifier(DebugEvent.RenderUnitUpdated);
if (traceIdentifier != null) {
HashMap<String, Object> attributes = new HashMap<>();
Expand Down

0 comments on commit 88ea915

Please sign in to comment.