chore(Android): migrate MessageQueueThread and it's implementation to Kotlin #48652
+281
−304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
TheRogue76
commented
Jan 13, 2025
| bgThread.start() | ||
|
|
||
| val pair = dataFuture.getOrThrow() | ||
| val looper = pair?.first ?: throw RuntimeException("Looper not found for thread") |
There was a problem hiding this comment.
Would love to know if this is ok, or another approach should be taken
|
@rshest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@rshest Can i know what the test that failed was doing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Continuing our usual journey, this time migrating MessageQueueThread. Was not expecting to see that many assertions in ReactContext.
One important thing to note on this PR: I had to add an extra Throw RuntimeException to
startNewBackgroundThread. It already had one from thedataFuture.getOrThrow(), but if your thread is not associated with a Looper, callingmyLooper(Line 203 of MessageQueueThreadImpl) Can return null. Until now, this would have been aNPE, i just decided to make it aRuntimeExceptionwith the messageLooper not found for thread. Let me know if you want me to make that function return a nullable, or throw another message or exception, or if you want me to treat Looper as Nullable in the whole class.Changelog:
[INTERNAL] [FIXED] - Migrate MessageQueueThread and MessageQueueThreadImpl to Kotlin
Test Plan: