Filter and Box Shadow Conversion Tests and Fixes #49418
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D69628917 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Feb 18, 2025
Summary: This adds some missing validation for negative blurs which should be considered parse error. Unit tests added for the forked props parsing code to validate more generally. Changelog: [Internal] Reviewed By: joevilches Differential Revision: D69628917
NickGerleman
force-pushed
the
export-D69628917
branch
from
c344cc5 to
c30093b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69628917 |
Summary: Relanding this change, now checking for the existing of FeatureFlags native module before checking it, with the assumption when the native module is unavailable (legacy arch) we will never do native processing, or even use the SVC. This aligns with the approach taken in `setupTimers` for the event loop, but is probably not the right long term solution for flags API. This also inlines a couple fixes originally up the stack, of missing propagation of inline state, and missing the gating in ReactNativeStyleAttributes. Changelog: [Internal] Reviewed By: joevilches Differential Revision: D69804412
…facebook#49504) Summary: We didn't have these cases before. Changelog: [Internal] Reviewed By: joevilches Differential Revision: D69433955
Summary: I want to go home 😭. This is not very pretty, while we are both keeping the old path, and trying to keep the props data types undisturbed for now, and support some of the stranger syntax we ended up supporting as inputs to filters. Changelog: [Internal] Reviewed By: joevilches Differential Revision: D69562718
Summary: This adds some missing validation for negative blurs which should be considered parse error. Unit tests added for the forked props parsing code to validate more generally. Changelog: [Internal] Reviewed By: joevilches Differential Revision: D69628917
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Feb 18, 2025
Summary: This adds some missing validation for negative blurs which should be considered parse error. Unit tests added for the forked props parsing code to validate more generally. Changelog: [Internal] Reviewed By: joevilches Differential Revision: D69628917
NickGerleman
force-pushed
the
export-D69628917
branch
from
c30093b to
f33f38b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69628917 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Feb 18, 2025
Summary: This adds some missing validation for negative blurs which should be considered parse error. Unit tests added for the forked props parsing code to validate more generally. Changelog: [Internal] Reviewed By: joevilches Differential Revision: D69628917
NickGerleman
force-pushed
the
export-D69628917
branch
2 times, most recently
from
ecb1861 to
84e1fd6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69628917 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D69628917 |
|
This pull request has been merged in 4fa5169. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This adds some missing validation for negative blurs which should be considered parse error, alongside a missing copy of inset state from CSSShadow to BoxShadow. Unit tests added for the forked props parsing code to validate more generally.
Changelog: [Internal]
Differential Revision: D69628917