-
Notifications
You must be signed in to change notification settings - Fork 47.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import React Concurrent Mode Profiler #19634
Merged
bvaughn
merged 131 commits into
facebook:master
from
MLH-Fellowship:scheduling-profiler-import
Aug 20, 2020
Merged
Changes from 1 commit
Commits
Show all changes
131 commits
Select commit
Hold shift + click to select a range
ef80d82
Checkin prototype with small example profile JSON
aeb7ac0
Auto-align flamegraph labels with edge of screen if scrolled partiall…
eed2ca6
Config changes
252e486
Added context menu
1a66278
STASHING
9887a57
Work in progress lanes
6fffde4
Merge pull request #4 from MLH-Fellowship/lanes
kartikcho 831357b
Upgrade dependencies
taneliang 240f9d3
Disable caching to fix tooltip bugs
kartikcho 56e9bb1
Merge pull request #5 from MLH-Fellowship/parcel-patch
kartikcho 8260bdc
Enable Flow in VS Code by adding flow-bin, .flowconfig and VS code se…
taneliang d0f9295
Merge pull request #6 from MLH-Fellowship/eliang/flow
kartikcho 63af326
Add type annotations (1/n) (#7)
taneliang 6379a2e
Add type annotations (2/n) (#8)
taneliang 178910b
Add Jest and configs
taneliang 80dea04
Fix yarn start Babel error
taneliang e027a56
Add demo test script
taneliang 87f7a7d
Revert "Add demo test script"
taneliang 6c7a9b3
Add yarn test script
taneliang ed38bc6
Merge pull request #15 from MLH-Fellowship/eliang/jest
kartikcho 7de190e
Codebase Restructure (#12)
kartikcho dab97b0
Add types for canvas files
taneliang 8f84396
Merge pull request #17 from MLH-Fellowship/eliang/type-canvas
kartikcho 363c258
Use React project Prettier configs (#21)
taneliang bb64e8c
Add ESLint (#22)
taneliang f4edd14
Implement new preprocessData and types to support new React marks (#20)
taneliang b691699
Add GitHub Actions workflow (#24)
taneliang 3d8c83e
Break App.js into CanvasPage and ImportPage (#25)
taneliang ea2ebfa
Fix preprocessDataV2 to prevent enormous React timestamps
taneliang daef39c
Merge pull request #28 from MLH-Fellowship/eliang/fix-enormous-timestamp
kartikcho dfdece8
Update proptypes to v2
kartikcho 97b1543
Break renderCanvas into small render* functions (#27)
taneliang a99e767
Separate v1 v2 data
kartikcho cba77ba
Remove setSchedulerCanvasHeight
kartikcho a5b3a41
Merge pull request #36 from MLH-Fellowship/migration-to-v2-data
kartikcho 02748cc
[Canvas V2][1/n] Implement display of measures (#31)
taneliang 0408565
[Canvas V2][2/n] Implement lane dividers and background (#32)
taneliang 92702a9
[Canvas V2][3/n] Implement React event row (#33)
taneliang c3eb419
[Canvas V2][4/n] Migrate hover and context menus (#34)
taneliang a73c9c4
Remove V1 types and usage
taneliang 04e81c3
Rename all *V2
taneliang 6fcac70
Merge pull request #46 from MLH-Fellowship/rm-v1
kartikcho cc0dec3
[Canvas V2][5/n] Improve getHoveredEvent clarity (#40)
taneliang b72cdda
Fix React data and flamegraph alignment (#53)
taneliang a74031b
Add minor EventTooltip improvements
taneliang ce2f361
Upgrade Parcel and Flow and fix Flow config (#58)
taneliang bcea552
Merge pull request #59 from MLH-Fellowship/eliang/improve-tooltips
kartikcho 3a5e663
Decrease lane height by 1/3, add note to react_gutter_size
kartikcho 0a67c96
Revert lane border size, rename REACT_PRIORITY_BORDER_SIZE to REACT_W…
kartikcho 8ce533f
Run Prettier
taneliang b640743
Fix nit: add space before comment text
taneliang 7958562
Decrease lane height (#60)
taneliang bdf7e65
Add Prettier errors to ESLint (#61)
taneliang 1d5991e
Add Import page and Import button (#64)
kartikcho 81ed6d5
Update preprocessData, add latest performance profile (#63)
kartikcho 3f78fdc
Add basic README (#66)
taneliang 02acac0
Fix Flow large memory usage (#79)
taneliang 8d98ae0
Remove link to a private internal repo (#81)
kartikcho 474a424
Fix tooltip bug, truncate componentName to use ellipsis (#78)
kartikcho 19b1fcf
Reimplement canvas using view classes (#80)
taneliang 963f62f
Add key mappings and legend to import page (#88)
kartikcho 8d22414
Fix lint failure from #88
taneliang 10a78e2
Tweak CI config to run on all branches and on check_suite (#94)
taneliang 415dc16
[Optimize flamechart][1/4] Add flamechart to ReactProfilerData
taneliang 26b62b9
Fix tests (#97)
taneliang 1f46ef2
[Optimize flamechart][2/4] Replace Speedscope types with custom stack…
taneliang 036e4c0
[Optimize flamechart][3/4] Rename flame graph -> flame chart
taneliang 2797f85
Fix strict mode error (#98)
kartikcho fe433c8
[Optimize flamechart][4/4] Split FlamechartView into row views
taneliang 2c79e71
Add Chromium flamechart colors (#96)
taneliang e0c29fb
Text animation fix (#106)
vikashchander 4385a12
[Improve base View][1/n] Add subview handling to View (#99)
taneliang 32a33b0
[Improve base View][2/n] Rationalize view layout system (#100)
taneliang ec3383b
[Improve base View][3/n] Add _ to views' private vars and methods (#101)
taneliang 492ef03
[Improve base View][4/n] Write tests for geometry.js (#102)
taneliang 7263953
Refactor tooltip label switch into a util (#103)
kartikcho 636c7ae
[Resize content][1/n] Break horizontal scrolling area into final-ish …
taneliang 6c4ad87
[Resize content][2/n] Implement ResizableSplitView (#107)
taneliang 1f0be0a
[Resize content][3/n] Sync horizontal pan and zoom states (#108)
taneliang 2f74a5c
Implement User Timing marks view (#109)
taneliang cb50ff8
Highlight React events with the same wakeable ID (#111)
taneliang 371ddf5
Improve Firefox scrolling performance (#114)
taneliang a115c58
Codemod pan/hover interactions -> mouse interactions (#115)
taneliang 2084197
Listen to mouse move events when dragging offscreen (#116)
taneliang 020916f
Upgrade dependencies, including Speedscope fork with upstreamed fix (…
taneliang 743da0c
Normalize wheel behavior across browsers (#117)
taneliang 92f4750
Reorganize layout and canvas folders (#120)
taneliang 09fbff4
Reimplement zoom to batch (#123)
taneliang d1b1b50
Fix tooltip (#121)
taneliang a530c70
Switch to concurrent React (#122)
taneliang 82ff1b3
Update color palette for accessibility (#126)
kartikcho 6c83208
[Import Prep][1/n] Upgrade dependencies (#128)
taneliang 42ed300
[Import Prep][2/n] Remove graveyard (#129)
taneliang 16b1fc2
[Import Prep][3/n] Remove unnecessary sample profiles (#130)
taneliang 89d5512
[Import Prep][4/n] Fix Flow errors (#133)
taneliang a42be68
[Import Prep][5/n] Deduplicate clamp, cleanup TODOs (#131)
taneliang 65415ec
[Import Prep][6/n] Update package.json (#132)
taneliang c73eca9
[Import Prep][7/n] Fix indeterministic test mark ordering (#127)
taneliang 1f5e9e3
Initializing empty merge repo
taneliang 0e9482a
Merge remote-tracking branch 'profiler/master'
taneliang ebe8133
Move everything into packages/react-scheduling-profiler
taneliang 9d61274
Merge remote-tracking branch 'profiler-importable/importable' into sc…
taneliang e132f9e
Integrate package.json, Flow, lint, Prettier, Yarn
taneliang 8522a69
Fix build
taneliang b078c0d
Remove unused service worker
taneliang 0602ebf
Upgrade Speedscope: switch module type to commonjs
taneliang b5f895c
Fix flow
taneliang d8f73f0
Fix most lint
taneliang cf3730d
Rename package react-scheduling-profiler -> react-devtools-scheduling…
taneliang 2fc46ad
Fix tests and add Flow coverage to 2 test files
taneliang 0f56751
Add FB copyright header
taneliang 9aa2195
Remove custom test setup
taneliang 3adb1cc
Rename page title
taneliang 223429d
Remove project .gitignore
taneliang 7e8725a
Replace Parcel with Webpack
taneliang a633ac3
Fix build by upgrading all @babel/* across repo
taneliang 9b2d982
Enable preprocessData errors in prod, fix tests
taneliang 42a59e6
Remove demo profile DEV-only autoload
taneliang 00a5b67
Merge remote-tracking branch 'upstream/master' into scheduling-profil…
taneliang c96c193
Move syncedHPAZVs into React ref and clean up CanvasPage imports
taneliang 826ca92
Resolve misc review comments
taneliang fbf4fd8
Adopt null coalescing operator to fix bug where 0 line/col becomes em…
taneliang 255a0dd
rename button classes
kartikcho 7c483a8
Remove interactor callback hook deps
taneliang 689b383
Hide open context menu before next one is shown
taneliang a0a6eb9
geometry.js: rectIntersectionWithRect -> intersectionOfRects, boundar…
taneliang 6c8756a
Inline --gradient-height CSS var
taneliang 8d276d4
Merge remote-tracking branch 'upstream/master' into scheduling-profil…
taneliang ca48ce3
geometry.js: make base types stricter
taneliang 4da3cf4
Add empty dep array to interactor useCallback
taneliang 5847027
Merge remote-tracking branch 'upstream/master' into scheduling-profil…
taneliang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should still pass a deps array to
useCallback
. That array should just be empty.Without the deps array,
useCallback
will just always pass the new function every time it's called.