FIXED MakeSwig.bat creates output + copy directories if needed #93
Conversation
|
I had this problem as well. I believe it's also a problem in the linux version of the script. |
|
|
||
| if not exist %swigOutputCsharp% ( mkdir %swigOutputCsharp% ) | ||
| if not exist %swigOutputCplusDLL% ( mkdir %swigOutputCplusDLL% ) | ||
| if not exist %swigInterface% ( mkdir %swigInterface% ) |
There was a problem hiding this comment.
The SwigInterfaceFiles directory should exist prior to running the MakeSwig batch file since it should contain the required interface files. Hence, creating this directory here should not really serve any purpose or am I overlooking anything?
| set swigOutputCsharp=SwigOutput\SwigCSharpOutput | ||
| set swigOutputCplusDLL=SwigOutput\CplusDLLIncludes | ||
| set swigInterface=SwigInterfaceFiles | ||
| set swigFiles=SwigWindowsCSharpSample\SwigTestApp\SwigFiles |
There was a problem hiding this comment.
Note that while you are introducing the variables here, the folder names are still hard coded throughout the batch file (f.e. in line 23).
Also corresponding changes should/could be applied to MakeSwigWithExtras.bat as well (not required in SLikeNet since there we combined the two batch files in a single one).
|
@kdavison: Due to lack of other means to contact you, posting this here as a comment: I understand that you didn't put your pull request under a special license and hence in our understanding it's covered by the original RakNet license. Please let me know if I got this wrong and you rather considering your contributions under special license terms. We applied the basic idea of your pull request in SLikeNet (internal case number: SLNET-193 - available already in the GitHub and SVN repositories - changes are scheduled to be shipped in SLikeNet 0.2.0: https://github.com/SLikeSoft/SLikeNet ) As a way to thank you for your contribution, we'd like to offer you putting you in the acknowledgments section of the accompanying readme for the next version: Please let me know if that's fine with you (preferably by mail to info [at] slikesoft [dot] com - or alternatively leave a comment here). Unless you explicitly say so, we won't put that entry in the readme file (to respect your privacy). |
|
I believe I made it using the standard raknet license but I will have to go
back and look at what I did.
It's been a while.
…On Fri, Jun 22, 2018, 3:22 PM Stefan Hett ***@***.***> wrote:
@kdavison <https://github.com/kdavison>: Due to lack of other means to
contact you, posting this here as a comment:
I understand that you didn't put your pull request under a special license
and hence in our understanding it's covered by the original RakNet license.
Please let me know if I got this wrong and you rather considering your
contributions under special license terms.
We applied the basic idea of your pull request in SLikeNet (available
already in the GitHub and SVN repositories - changes are scheduled to be
shipped in SLikeNet 0.2.0): https://github.com/SLikeSoft/SLikeNet
As a way to thank you for your contribution, we'd like to offer you
putting you in the acknowledgments section of the accompanying readme for
the next version:
kdavison: https://github.com/kdavison (pull request: RAKNET_93)
Please let me know if that's fine with you (preferably by mail to info
[at] slikesoft [dot] com - or alternatively leave a comment here). Unless
you explicitly say so, we won't put that entry in the readme file (to
respect your privacy).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#93 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AF2R2O9HlhNzw1QqyUBaydmg7gARrSobks5t_VHxgaJpZM4H1yBf>
.
|
Had issue in MSVS 2015 Community where MakeSwig.bat did not create directories as needed.
Fixed MakeSwig.bat by creating some variables for the output / copy directories and creating those directories if they did not exist.