Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Configuration File and Management #8

Merged
merged 3 commits into from
Sep 11, 2023
Merged

Conversation

hunterjackson
Copy link
Contributor

No description provided.

Copy link
Contributor

@colinmccloskey colinmccloskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

config changes all look good to me

class RootConfigurationTest {
private static final String TOML =
"""
port = 8081
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: formatting

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually the way it has to be, otherwise there are spaces in the text in the file we write to disk.

@hunterjackson hunterjackson merged commit 9e3b1c3 into main Sep 11, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants