Add initial support for Zen5 and claritfy Zen3 vs Zen5 CPU family #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62447334 |
|
This pull request was exported from Phabricator. Differential Revision: D62447334 |
bigzachattack
added a commit
to bigzachattack/dynolog-1
that referenced
this pull request
Sep 27, 2024
…ly (facebookincubator#295) Summary: Pull Request resolved: facebookincubator#295 This diff includes changes in hbt to support adding Zen5 CPUs. `CpuFamily::AMD` has been renamed `CpuFamily::AMDZEN3` and adds `CpuFamily::AMDZEN5`, since AMD changes families more often than Intel. Reviewed By: briancoutinho Differential Revision: D62447334
bigzachattack
force-pushed
the
export-D62447334
branch
from
6a7abf6
to
4099f16
Compare
Summary: Update json_events to include metrics in BuiltinMetricsLight that are used by Dynolog. Differential Revision: D62405387
…ly (facebookincubator#295) Summary: Pull Request resolved: facebookincubator#295 This diff includes changes in hbt to support adding Zen5 CPUs. `CpuFamily::AMD` has been renamed `CpuFamily::AMDZEN3` and adds `CpuFamily::AMDZEN5`, since AMD changes families more often than Intel. Reviewed By: briancoutinho Differential Revision: D62447334
|
This pull request was exported from Phabricator. Differential Revision: D62447334 |
bigzachattack
force-pushed
the
export-D62447334
branch
from
4099f16
to
f4d02db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff includes changes in hbt to support adding Zen5 CPUs.
CpuFamily::AMDhas been renamedCpuFamily::AMDZEN3and addsCpuFamily::AMDZEN5, since AMD changes families more often than Intel.Differential Revision: D62447334