Address code quality warnings (3/N: unused-parameter) (#17)

Summary: Pull Request resolved: #17 Differential Revision: D58827924
facebookincubator · Jun 20, 2024 · 441cd6d · 441cd6d
1 parent 331ecb5
commit 441cd6d
Show file tree

Hide file tree

Showing 8 changed files with 17 additions and 19 deletions.
diff --git a/momentum/character_sequence_solver/model_parameters_sequence_error_function.cpp b/momentum/character_sequence_solver/model_parameters_sequence_error_function.cpp
@@ -59,7 +59,7 @@ double ModelParametersSequenceErrorFunctionT<T>::getError(
 template <typename T>
 double ModelParametersSequenceErrorFunctionT<T>::getGradient(
     gsl::span<const ModelParametersT<T>> modelParameters,
-    gsl::span<const SkeletonStateT<T>> skelStates,
+    gsl::span<const SkeletonStateT<T>> /* skelStates */,
     Eigen::Ref<Eigen::VectorX<T>> gradient) const {
   // ignore if we don't have any reasonable data
   if (targetWeights_.size() !=
@@ -98,7 +98,7 @@ size_t ModelParametersSequenceErrorFunctionT<T>::getJacobianSize() const {
 template <typename T>
 double ModelParametersSequenceErrorFunctionT<T>::getJacobian(
     gsl::span<const ModelParametersT<T>> modelParameters,
-    gsl::span<const SkeletonStateT<T>> skelStates,
+    gsl::span<const SkeletonStateT<T>> /* skelStates */,
     Eigen::Ref<Eigen::MatrixX<T>> jacobian,
     Eigen::Ref<Eigen::VectorX<T>> residual,
     int& usedRows) const {

diff --git a/momentum/character_sequence_solver/state_sequence_error_function.cpp b/momentum/character_sequence_solver/state_sequence_error_function.cpp
@@ -49,7 +49,7 @@ void StateSequenceErrorFunctionT<T>::setTargetWeights(
 
 template <typename T>
 double StateSequenceErrorFunctionT<T>::getError(
-    gsl::span<const ModelParametersT<T>> modelParameters,
+    gsl::span<const ModelParametersT<T>> /* modelParameters */,
     gsl::span<const SkeletonStateT<T>> skelStates) const {
   MT_PROFILE_EVENT("StateSequenceError: getError");
 
@@ -85,7 +85,7 @@ double StateSequenceErrorFunctionT<T>::getError(
 
 template <typename T>
 double StateSequenceErrorFunctionT<T>::getGradient(
-    gsl::span<const ModelParametersT<T>> modelParameters,
+    gsl::span<const ModelParametersT<T>> /* modelParameters */,
     gsl::span<const SkeletonStateT<T>> skelStates,
     Eigen::Ref<Eigen::VectorX<T>> gradient) const {
   MT_PROFILE_EVENT("StateSequenceError: getGradient");
@@ -206,7 +206,7 @@ size_t StateSequenceErrorFunctionT<T>::getJacobianSize() const {
 
 template <typename T>
 double StateSequenceErrorFunctionT<T>::getJacobian(
-    gsl::span<const ModelParametersT<T>> modelParameters,
+    gsl::span<const ModelParametersT<T>> /* modelParameters */,
     gsl::span<const SkeletonStateT<T>> skelStates,
     Eigen::Ref<Eigen::MatrixX<T>> jacobian_full,
     Eigen::Ref<Eigen::VectorX<T>> residual_full,

diff --git a/momentum/character_solver/vertex_error_function.cpp b/momentum/character_solver/vertex_error_function.cpp
@@ -310,7 +310,7 @@ void VertexErrorFunctionT<T>::calculateDWorldPos(
 
 template <typename T>
 double VertexErrorFunctionT<T>::calculatePositionGradient(
-    const ModelParametersT<T>& modelParameters,
+    const ModelParametersT<T>& /* modelParameters */,
     const SkeletonStateT<T>& state,
     const VertexConstraintT<T>& constr,
     Eigen::Ref<Eigen::VectorX<T>> gradient) const {
@@ -415,7 +415,7 @@ double VertexErrorFunctionT<T>::calculatePositionGradient(
 
 template <typename T>
 double VertexErrorFunctionT<T>::calculatePositionJacobian(
-    const ModelParametersT<T>& modelParameters,
+    const ModelParametersT<T>& /* modelParameters */,
     const SkeletonStateT<T>& state,
     const VertexConstraintT<T>& constr,
     Ref<Eigen::MatrixX<T>> jac,
@@ -521,7 +521,7 @@ double VertexErrorFunctionT<T>::calculatePositionJacobian(
 
 template <typename T>
 double VertexErrorFunctionT<T>::calculateNormalGradient(
-    const ModelParametersT<T>& modelParameters,
+    const ModelParametersT<T>& /* modelParameters */,
     const SkeletonStateT<T>& state,
     const VertexConstraintT<T>& constr,
     const T sourceNormalWeight,
@@ -629,7 +629,7 @@ double VertexErrorFunctionT<T>::calculateNormalGradient(
 
 template <typename T>
 double VertexErrorFunctionT<T>::calculateNormalJacobian(
-    const ModelParametersT<T>& modelParameters,
+    const ModelParametersT<T>& /* modelParameters */,
     const SkeletonStateT<T>& state,
     const VertexConstraintT<T>& constr,
     const T sourceNormalWeight,

diff --git a/momentum/diff_ik/fully_differentiable_motion_error_function.cpp b/momentum/diff_ik/fully_differentiable_motion_error_function.cpp
@@ -81,7 +81,7 @@ template <typename T>
 Eigen::VectorX<T> FullyDifferentiableMotionErrorFunctionT<T>::d_gradient_d_input_dot(
     const std::string& inputName,
     const ModelParametersT<T>& params,
-    const SkeletonStateT<T>& state,
+    const SkeletonStateT<T>& /* state */,
     Eigen::Ref<const Eigen::VectorX<T>> inputVec) {
   // The error function is just
   //    \sum_i (w_i * (param_i - targetParam_i))^2

diff --git a/momentum/diff_ik/fully_differentiable_pose_prior_error_function.cpp b/momentum/diff_ik/fully_differentiable_pose_prior_error_function.cpp
@@ -194,7 +194,7 @@ template <typename T>
 Eigen::VectorX<T> FullyDifferentiablePosePriorErrorFunctionT<T>::d_gradient_d_input_dot(
     const std::string& inputName,
     const ModelParametersT<T>& params,
-    const SkeletonStateT<T>& state,
+    const SkeletonStateT<T>& /* state */,
     Eigen::Ref<const Eigen::VectorX<T>> inputVec) {
   if (!this->posePrior_) {
     throw std::runtime_error("No pose prior loaded, can't set values.");

diff --git a/momentum/diff_ik/fully_differentiable_state_error_function.cpp b/momentum/diff_ik/fully_differentiable_state_error_function.cpp
@@ -166,7 +166,7 @@ JetType FullyDifferentiableStateErrorFunctionT<T>::calculateGradient_dot(
 template <typename T>
 Eigen::VectorX<T> FullyDifferentiableStateErrorFunctionT<T>::d_gradient_d_input_dot(
     const std::string& inputName,
-    const ModelParametersT<T>& params,
+    const ModelParametersT<T>& /* params */,
     const SkeletonStateT<T>& state,
     Eigen::Ref<const Eigen::VectorX<T>> inputVec) {
   const auto& targetState = this->getTargetState();

diff --git a/momentum/io/gltf/gltf_io.cpp b/momentum/io/gltf/gltf_io.cpp
@@ -100,7 +100,7 @@ Locator createLocator(const fx::gltf::Node& node, const nlohmann::json& extensio
   return loc;
 }
 
-Joint createJoint(const fx::gltf::Node& node, const nlohmann::json& extension) {
+Joint createJoint(const fx::gltf::Node& node) {
   Joint joint;
   joint.name = node.name;
   joint.parent = kInvalidIndex;
@@ -303,7 +303,7 @@ void loadHierarchyRecursive(
     locators.push_back(loc);
     nodeToObjectMap[nodeId] = locators.size() - 1;
   } else if ((!useExtension && (node.mesh < 0)) || type == "skeleton_joint") {
-    Joint joint = createJoint(node, extension);
+    Joint joint = createJoint(node);
     joint.parent = parentJointId;
     joints.push_back(joint);
     nodeToObjectMap[nodeId] = joints.size() - 1;
@@ -611,9 +611,7 @@ void loadGlobalExtensions(const fx::gltf::Document& model, Character& character)
   }
 }
 
-Character populateCharacterFromModel(
-    const fx::gltf::Document& model,
-    const filesystem::path& filename) {
+Character populateCharacterFromModel(const fx::gltf::Document& model) {
   // #TODO: set character name
   Character result;
 
@@ -852,7 +850,7 @@ Character loadGltfCharacter(fx::gltf::Document& model) {
   // ---------------------------------------------
   Character result;
   try {
-    result = populateCharacterFromModel(model, "in-document");
+    result = populateCharacterFromModel(model);
   } catch (std::runtime_error& err) {
     throw std::runtime_error(fmt::format("Unable to load gltf : {}", std::string(err.what())));
   }

diff --git a/momentum/io/gltf/utils/accessor_utils.hpp b/momentum/io/gltf/utils/accessor_utils.hpp
@@ -106,7 +106,7 @@ std::vector<T> copyAlignedAccessorBuffer(const fx::gltf::Document& model, int32_
 
 // template to set accessor
 template <typename T>
-void setAccessorType(fx::gltf::Accessor& accessor) {
+void setAccessorType(fx::gltf::Accessor& /* accessor */) {
   throw std::runtime_error("Unsupported data type");
 }