Fix for bug in linear constraint gradient. #161
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66893638 |
jeongseok-meta
pushed a commit
that referenced
this pull request
Dec 7, 2024
Summary: It turned out we were missing a weight, which I noticed when I changed the weight to be something other than 1. Reviewed By: jeongseok-meta Differential Revision: D66893638
jeongseok-meta
force-pushed
the
export-D66893638
branch
from
6515bbb to
7aec410
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66893638 |
jeongseok-meta
pushed a commit
that referenced
this pull request
Dec 9, 2024
Summary: It turned out we were missing a weight, which I noticed when I changed the weight to be something other than 1. Reviewed By: jeongseok-meta Differential Revision: D66893638
jeongseok-meta
force-pushed
the
export-D66893638
branch
from
7aec410 to
aca363e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66893638 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 9, 2024
Summary: It turned out we were missing a weight, which I noticed when I changed the weight to be something other than 1. Reviewed By: jeongseok-meta Differential Revision: D66893638
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 9, 2024
Summary: It turned out we were missing a weight, which I noticed when I changed the weight to be something other than 1. Reviewed By: jeongseok-meta Differential Revision: D66893638
Summary: It turned out we were missing a weight, which I noticed when I changed the weight to be something other than 1. Reviewed By: jeongseok-meta Differential Revision: D66893638
jeongseok-meta
force-pushed
the
export-D66893638
branch
from
aca363e to
0016a40
Compare
jeongseok-meta
pushed a commit
that referenced
this pull request
Dec 10, 2024
Summary: It turned out we were missing a weight, which I noticed when I changed the weight to be something other than 1. Reviewed By: jeongseok-meta Differential Revision: D66893638
jeongseok-meta
pushed a commit
that referenced
this pull request
Dec 10, 2024
Summary: It turned out we were missing a weight, which I noticed when I changed the weight to be something other than 1. Reviewed By: jeongseok-meta Differential Revision: D66893638
|
This pull request was exported from Phabricator. Differential Revision: D66893638 |
jeongseok-meta
pushed a commit
that referenced
this pull request
Dec 10, 2024
Summary: It turned out we were missing a weight, which I noticed when I changed the weight to be something other than 1. Reviewed By: jeongseok-meta Differential Revision: D66893638
jeongseok-meta
pushed a commit
that referenced
this pull request
Dec 10, 2024
Summary: It turned out we were missing a weight, which I noticed when I changed the weight to be something other than 1. Reviewed By: jeongseok-meta Differential Revision: D66893638
jeongseok-meta
pushed a commit
that referenced
this pull request
Dec 10, 2024
Summary: It turned out we were missing a weight, which I noticed when I changed the weight to be something other than 1. Reviewed By: jeongseok-meta Differential Revision: D66893638
|
This pull request has been merged in ade373f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: It turned out we were missing a weight, which I noticed when I changed the weight to be something other than 1.
Reviewed By: jeongseok-meta
Differential Revision: D66893638