remove legacy cross() usage #20
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D58848086 |
Summary: Pull Request resolved: #20 Fix legacy cross usage. Future cross() call must have explicit dim parameter. Currently it has warning: ``` Warning: Using torch.cross without specifying the dim arg is deprecated. Please either pass the dim explicitly or simply use torch.linalg.cross. The default value of dim will change to agree with that of linalg.cross in a future release. (function operator()) ``` Reviewed By: yutingye Differential Revision: D58848086
|
This pull request was exported from Phabricator. Differential Revision: D58848086 |
jeongseok-meta
force-pushed
the
export-D58848086
branch
from
42c8460 to
6665aed
Compare
|
This pull request has been merged in f832c35. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fix legacy cross usage. Future cross() call must have explicit dim parameter.
Currently it has warning:
Reviewed By: yutingye
Differential Revision: D58848086