Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(simdjson): Add CMake option to skip utf8 validation #12165

Closed
wants to merge 1 commit into from
Closed

build(simdjson): Add CMake option to skip utf8 validation #12165

wants to merge 1 commit into from

Conversation

marin-ma
Copy link
Contributor

@marin-ma marin-ma commented Jan 24, 2025 •
edited by majetideepak
Loading

Add VELOX_SIMDJSON_SKIPUTF8VALIDATION CMake option to do this.

Discussed in #10639 (comment)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 24, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 24, 2025 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 0612e3f
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/6793738f12a71100081a27a6

@marin-ma
Copy link
Contributor Author

@majetideepak @rui-mo Could you help to review? Thanks!

@majetideepak majetideepak changed the title build(cmake): Add build option for skipping simdjson utf8 validation build(simdjson): Add option to skip utf8 validation Jan 24, 2025
@majetideepak majetideepak changed the title build(simdjson): Add option to skip utf8 validation build(simdjson): Add CMake option to skip utf8 validation Jan 24, 2025
@majetideepak majetideepak added the ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall label Jan 24, 2025
@marin-ma
Copy link
Contributor Author

@assignUser Could you help to review? Thanks!

@facebook-github-bot
Copy link
Contributor

@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

xiaoxmeng
xiaoxmeng reviewed Jan 28, 2025
View reviewed changes
Copy link
Contributor

@xiaoxmeng xiaoxmeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marin-ma there is a py/spark CI failure and is it related? thanks!

@marin-ma
Copy link
Contributor Author

@marin-ma there is a py/spark CI failure and is it related? thanks!

@xiaoxmeng I don't think this failure is related. This patch doesn't change the default build options. Is it possible to trigger.a re-run? Thanks!

@facebook-github-bot
Copy link
Contributor

@xiaoxmeng merged this pull request in a837ebd.

@conbench-facebook conbench-facebook
Copy link

Conbench analyzed the 1 benchmark run on commit a837ebd9.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaoxmeng xiaoxmeng xiaoxmeng left review comments

@majetideepak majetideepak majetideepak approved these changes

@assignUser assignUser assignUser approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@marin-ma @facebook-github-bot @majetideepak @assignUser @xiaoxmeng