feat(python): Make output-schema optional on tableWrite #12296
Closed
+21
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: output schema should be optional; by default is uses whatever schema is produced by the upstream operator. Differential Revision: D69406743
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D69406743 |
✅ Deploy Preview for meta-velox canceled.
|
pedroerp
requested review from
kevinwilfong and
kgpai
and removed request for
kgpai
|
LGTM. Ignoring the test timeouts as they are unrelated to this diff and the fix for those is on its way to landing. |
kostasxmeta
approved these changes
Feb 10, 2025
|
This pull request was exported from Phabricator. Differential Revision: D69406743 |
|
This pull request has been merged in 04bfdff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
output schema should be optional; by default is uses whatever schema
is produced by the upstream operator.
Differential Revision: D69406743