fix(fuzzer): Allow large error with global aggregation of approx_distinct #12323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inct Summary: The approx_distinct function only guarantees the standard deviation of error distribution when there is a large number of groups. With global aggregation, it should be allowed if approx_distinct produces a large error. This diff relaxes the ApproxDistinctResultVerifier to allow large errors with global aggregations. Differential Revision: D69611305
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D69611305 |
✅ Deploy Preview for meta-velox canceled.
|
Yuhta
approved these changes
Feb 13, 2025
|
This pull request has been merged in 0d0a815. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The approx_distinct function only guarantees the standard deviation of error distribution when there is a large number of groups. With global aggregation, it should be allowed if approx_distinct produces a large error. This diff relaxes the ApproxDistinctResultVerifier to allow large errors with global aggregations.
Differential Revision: D69611305