-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New testing option for ec2 (reuse existing server) #1036
Conversation
For the sample commands (e.g. |
In this case I ran the above from a sample folder. True proper documentation should note the frame of reference, and when the feature is documented that would be good. |
Since the main bottleneck is assembly of NodeJS part (while Python part sails through quickly), in the ideal world we'd cache the NodeJS build, while allowing to alter Python and/or YAML files. Not sure if this piecemeal caching is possible here. |
print(f"Ec2: Deleting server: {self.server_id}") | ||
if self.router_rule_arn is not None: | ||
ec2_helpers.delete_rule( | ||
if self._deploy_type == "standard": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if deploy type is different, I suggest to output an INFO message here saying that for deploy type X the server continue to live, and needs to be shut down manually via cleanup command.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The warning message appears on launch for the retain
server currently. Feel free to add additional logging elsewhere as appropriate.
self.fallback_details["key_pair_name"], | ||
server_dir, | ||
) | ||
print("EC2: Starting instance...") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could include here what deploy type this is
Indeed - this I'd consider to be future work, requiring splitting the setup part of the server from the package/deploy part, and only running the setup part on initial launch, but instead running a content wipe for the latter. |
Overview
For some reason, redeploying servers to EC2 has become increasingly painful due to delays downloading the required resources. This option allows reuse of an existing server, with the following workflow:
Deploy
Reuse
Cleanup
note: No new files are pushed to the server, so no actual changes to tasks will be reflected with this option currently. @meta-paul this may be something worth expanding on.
note 2: Only one Mephisto task can be actively serviced by a routing server, so this should not be used to connect to servers that are in-use.