Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up TODO comments #1050

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Clean up TODO comments #1050

merged 1 commit into from
Aug 17, 2023

Conversation

meta-paul
Copy link
Contributor

Address/remove TODO comments in the Prolific Integration code

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 17, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: +0.05% 🎉

Comparison is base (a5a90f2) 60.36% compared to head (530295c) 60.42%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1050      +/-   ##
==========================================
+ Coverage   60.36%   60.42%   +0.05%     
==========================================
  Files         155      155              
  Lines       11811    11811              
==========================================
+ Hits         7130     7137       +7     
+ Misses       4681     4674       -7     
Files Changed Coverage Δ
...o/abstractions/providers/prolific/api/constants.py 100.00% <ø> (ø)
...ement_classes/age_range_eligibility_requirement.py 58.33% <ø> (ø)
.../abstractions/providers/prolific/prolific_agent.py 27.92% <ø> (ø)
...tractions/providers/prolific/prolific_datastore.py 29.37% <ø> (ø)
...o/abstractions/providers/prolific/prolific_unit.py 19.56% <ø> (ø)
.../abstractions/providers/prolific/prolific_utils.py 19.07% <ø> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@meta-paul meta-paul merged commit 1f540f9 into main Aug 17, 2023
13 checks passed
@JackUrb JackUrb deleted the clanup-todo-1008-comments branch September 14, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants