Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes from local branch #1054

Merged
merged 2 commits into from
Aug 21, 2023
Merged

Small fixes from local branch #1054

merged 2 commits into from
Aug 21, 2023

Conversation

JackUrb
Copy link
Contributor

@JackUrb JackUrb commented Aug 21, 2023

Collection of small bugfixes and convenience updates that I had in a local branch.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 21, 2023
@JackUrb JackUrb marked this pull request as ready for review August 21, 2023 19:54
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 78.94% and project coverage change: -0.08% ⚠️

Comparison is base (72e1deb) 60.42% compared to head (1ea3da9) 60.35%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1054      +/-   ##
==========================================
- Coverage   60.42%   60.35%   -0.08%     
==========================================
  Files         155      155              
  Lines       11813    11822       +9     
==========================================
- Hits         7138     7135       -3     
- Misses       4675     4687      +12     
Files Changed Coverage Δ
...ephisto/abstractions/architects/ec2/ec2_helpers.py 17.49% <0.00%> (ø)
mephisto/operations/worker_pool.py 80.12% <50.00%> (-0.20%) ⬇️
mephisto/operations/operator.py 70.52% <85.71%> (+0.59%) ⬆️
...nts/remote_procedure/remote_procedure_blueprint.py 43.87% <100.00%> (+0.57%) ⬆️
mephisto/data_model/agent.py 75.71% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JackUrb JackUrb merged commit c15e0d3 into main Aug 21, 2023
13 checks passed
@JackUrb JackUrb deleted the small-fixes-2 branch August 21, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants