Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove prometheus/grafana executables from docker context #754

Merged
merged 1 commit into from
Apr 7, 2022

Conversation

pringshia
Copy link
Contributor

@pringshia pringshia commented Apr 7, 2022

Overview

Partially addresses a bug surfaced via #752 and #744 in that metrics executables saved down on the host computer would be copied into the Docker context and cause issues when running the docker image due to architecture mismatches.

This was fixed by updating the .dockerignore file

Testing

docker build -t mephisto .
docker run -p 3000:3000 mephisto bash -c \
    'cd mephisto/examples/simple_static_task && python static_test_script.py'

...

[2022-04-07 21:04:03,109][mephisto.abstractions.providers.mock.mock_unit][INFO] - Mock task launched: localhost:3000 for preview, localhost:3000/?worker_id=x&assignment_id=4 for assignment 2

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 7, 2022
@pringshia pringshia requested a review from JackUrb April 7, 2022 21:04
@pringshia pringshia added the fix Small fixes and cleanups label Apr 7, 2022
Copy link
Contributor

@JackUrb JackUrb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@pringshia pringshia merged commit 98d1b54 into main Apr 7, 2022
@pringshia pringshia deleted the update-dockerignore branch April 7, 2022 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fix Small fixes and cleanups
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants